Conversation
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information @facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 28, 2017
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 21, 2019
Summary: This sync includes these changes: - **[bb1853f73](react/react@bb1853f73 )**: [Native] If statement cleanup for null targets (#17346) //<Eli White>// - **[a9d9fc7bb](react/react@a9d9fc7bb )**: [Native] Add FeatureFlag to dispatch events with instance currentTarget (#17345) //<Eli White>// - **[731456a12](react/react@731456a12 )**: [Native] Add FeatureFlag to dispatch events with instance targets (#17323) //<Eli White>// - **[9d5363820](react/react@9d5363820 )**: Change legacy-events plugin nativeEventTarget to allow null (#17344) //<Eli White>// Changelog: [General][Changed] Partial React Sync from 6cff70a74...bb1853f73 Reviewed By: mdvacca Differential Revision: D18626496 fbshipit-source-id: c8fc6551bf2b37ce27d4e9dbc7fe3455dfa08af9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buck is failing due to missing args: https://circleci.com/gh/facebook/react-native/29268