SectionList renderItem should be optional#17262
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
|
Thanks for the fix! @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
4 participants
Motivation
renderItemonSectionListis within theOptionalPropsgroup of props but it is not actually marked as optional. Which means that doing things such as in the example where each section has its ownrenderItemand norenderItemprop is passed intoSectionListwill fail flow.Test Plan
Create a
SectionListwhere each section has it's ownrenderItemand do not pass in arenderItemintoSectionList. Run flow, it should error.Release Notes
[GENERAL] [MINOR] [SectionList] -Makes
renderItemprop onSectionListoptional for flow.