Set minHeight instead of minWidth for calculating the layout in RCTSurfaceRootShadowView#17203
Closed
maicki wants to merge 1 commit into
Closed
Set minHeight instead of minWidth for calculating the layout in RCTSurfaceRootShadowView#17203maicki wants to merge 1 commit into
maicki wants to merge 1 commit into
Conversation
…TSurfaceRootShadowView
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information @facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
Contributor
Author
|
@shergin Hey - could you please take a look at this PR. If this would go into a public release we would have to manually patch it in this release if we would like to use it. Thanks! |
Contributor
|
@maicki Oh, sorry, I missed this. Sure! |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 28, 2017
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@maicki Just curious, where do you use this? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix calculating layout in
RCTSurfaceRootShadowViewas theminWidthis set doubled incalculateLayoutWithMinimumSize:maximumSize:.cc @shergin