Skip to content

[WebView] Support opening WebView links in external browser on iOS#1355

Closed
masonicboom wants to merge 1 commit into
react:masterfrom
masonicboom:open-webview-links-externally
Closed

[WebView] Support opening WebView links in external browser on iOS#1355
masonicboom wants to merge 1 commit into
react:masterfrom
masonicboom:open-webview-links-externally

Conversation

@masonicboom

@masonicboom masonicboom commented May 20, 2015

Copy link
Copy Markdown

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2015
a2
a2 reviewed May 22, 2015
View reviewed changes
Comment thread React/Views/RCTWebView.h

@a2 a2 May 22, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

BOOL openLinksInExternalBrowser;

@masonicboom masonicboom May 22, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a2 What does that mean? Does that line have a mistake?

@arunshan

arunshan commented May 26, 2015

Copy link
Copy Markdown

I tried using your PR and I am not able to get the links to open in external browser. I think this only works with but not with jquery on click listeners.

@masonicboom

masonicboom commented May 27, 2015

Copy link
Copy Markdown
Author

@arunshan can you post some code that exposes the issue you're seeing?

@brentvatne brentvatne changed the title Support opening WebView links in external browser on iOS [WebView] Support opening WebView links in external browser on iOS Jun 1, 2015
@ghost

ghost commented Aug 5, 2015

Copy link
Copy Markdown

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@paramaggarwal

paramaggarwal commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

@arunshan Yes, that is expected. The URL is never seen by the native webview itself if the click is handled completely by jQuery/JS. It would be an AJAX call and not a complete page reload.

All, any other concerns with this PR?

@jaygarcia jaygarcia mentioned this pull request Dec 11, 2015
Closed
@satya164

satya164 commented Dec 22, 2015

Copy link
Copy Markdown
Contributor

Any updates on this?

@facebook-github-bot

facebook-github-bot commented Dec 22, 2015

Copy link
Copy Markdown
Contributor

@masonicboom updated the pull request.

@satya164

satya164 commented Jan 26, 2016

Copy link
Copy Markdown
Contributor

Closing since no activity on the PR. let's re-open if you wanna work on it again.

@satya164 satya164 closed this Jan 26, 2016
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2022
Open
@bumplzz69 bumplzz69 mentioned this pull request Sep 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nicklockwood nicklockwood

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@masonicboom @arunshan @paramaggarwal @satya164 @facebook-github-bot @a2 @nicklockwood @reactjs-bot