[Webview]: set mediaPlaybackRequiresUserAction as true by default (io…#12483
Closed
SuperBesse wants to merge 1 commit into
Closed
[Webview]: set mediaPlaybackRequiresUserAction as true by default (io…#12483SuperBesse wants to merge 1 commit into
SuperBesse wants to merge 1 commit into
Conversation
Contributor
|
The docs claim the default value to be false. This PR would change the current behavior. |
Author
Where is the real documentation ? |
Contributor
|
I'm basing this purely on what your PR submitted (e.g. you did not mention the above in your original post). I suggest verifying what the actual default behavior is, and updating the docs to reflect that (as opposed to switching the default behavior to match the docs). |
Author
|
Ok i understand what you mean but on IOS component, the documentation is: My PR want just be coherent with website documentation and with the IOS component behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In documentation, the default value of mediaPlaybackRequiresUserAction is true. But in reality, on ios and android, this value is false.
So to fix it, i update default value for android webview and define default props for ios with mediaPlaybackRequiresUserAction to true.