#114 - stop requiring docblock for JSX transformer#418
Closed
SanderSpies wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Incomplete. |
Contributor
|
👍 |
Contributor
|
@SanderSpies it seems like this PR is outdated and is causing some simple merge conflicts ( |
Contributor
There was a problem hiding this comment.
this could be simplified to return object.type === Syntax.XJSElement && (jsx == null || jsx === 'React.DOM');
Contributor
There was a problem hiding this comment.
Sorry, I believe that from this comment of @jeffmo #364 (comment) he actually meant return object.type === Syntax.XJSElement && (!jsx || jsx === 'React.DOM');
Contributor
|
What's the status here. Do we want to go forward with this change? |
Contributor
|
This PR is 3 months old. I'm going to close it out. Feel free to re-open the issue. |
FrozenPandaz
added a commit
to nrwl/nx
that referenced
this pull request
Jul 15, 2026
…eywords (#36326) ## Current Behavior `nx release changelog` extracts issue references from the commit body with a bare `/(#\d+)/gm` regex, so **every** `#number` in a squashed PR description becomes an issue link in the changelog — including other repos' issue numbers. For example, the [23.1.0 release notes](https://github.com/nrwl/nx/releases/tag/23.1.0) contain: > **rspack:** support @rspack/core@2 and @rsbuild/core@2 (multi-version compliance) (#35682, #35764, #13420, #781) where `#13420` is actually `web-infra-dev/rspack#13420` and `#781` is `privatenumber/tsx#781` — upstream issues discussed in the PR description, rendered as (bogus) `nrwl/nx` issue links. The same release also picked up `nrwl/nx-console#3175`, `react/react#418`, and `web-infra-dev/rspack#2292`, plus noisy same-repo PR mentions that were merely referenced in prose. ## Expected Behavior Issue references are only extracted from the commit body when linked via a GitHub closing keyword (`Fixes #123`, `Closes #123`, `Resolves: #123`, ...) — the same rule GitHub itself uses to auto-link and close issues. Cross-repo forms (`owner/repo#123`), markdown links to other repos, and casual same-repo mentions no longer produce changelog references. Subject-line extraction (the PR number in `(#123)` and inline issue refs) is unchanged. Both regular commits and version plans go through the same `extractReferencesFromCommit` function, so this fixes both paths. ## Related Issue(s) N/A <!-- polygraph-session-start --> --- [View session information ↗](https://app.trypolygraph.com/orgs/6a061dcb561c062131116eca/sessions/Fix-nx-release-changelog-scraping-other-repos-issue-numbers-7967dd62) <!-- polygraph-session-end -->
AgentEnder
pushed a commit
to nrwl/nx
that referenced
this pull request
Jul 17, 2026
…eywords (#36326) ## Current Behavior `nx release changelog` extracts issue references from the commit body with a bare `/(#\d+)/gm` regex, so **every** `#number` in a squashed PR description becomes an issue link in the changelog — including other repos' issue numbers. For example, the [23.1.0 release notes](https://github.com/nrwl/nx/releases/tag/23.1.0) contain: > **rspack:** support @rspack/core@2 and @rsbuild/core@2 (multi-version compliance) (#35682, #35764, #13420, #781) where `#13420` is actually `web-infra-dev/rspack#13420` and `#781` is `privatenumber/tsx#781` — upstream issues discussed in the PR description, rendered as (bogus) `nrwl/nx` issue links. The same release also picked up `nrwl/nx-console#3175`, `react/react#418`, and `web-infra-dev/rspack#2292`, plus noisy same-repo PR mentions that were merely referenced in prose. ## Expected Behavior Issue references are only extracted from the commit body when linked via a GitHub closing keyword (`Fixes #123`, `Closes #123`, `Resolves: #123`, ...) — the same rule GitHub itself uses to auto-link and close issues. Cross-repo forms (`owner/repo#123`), markdown links to other repos, and casual same-repo mentions no longer produce changelog references. Subject-line extraction (the PR number in `(#123)` and inline issue refs) is unchanged. Both regular commits and version plans go through the same `extractReferencesFromCommit` function, so this fixes both paths. ## Related Issue(s) N/A <!-- polygraph-session-start --> --- [View session information ↗](https://app.trypolygraph.com/orgs/6a061dcb561c062131116eca/sessions/Fix-nx-release-changelog-scraping-other-repos-issue-numbers-7967dd62) <!-- polygraph-session-end -->
FrozenPandaz
added a commit
to nrwl/nx
that referenced
this pull request
Jul 20, 2026
…eywords (#36326) ## Current Behavior `nx release changelog` extracts issue references from the commit body with a bare `/(#\d+)/gm` regex, so **every** `#number` in a squashed PR description becomes an issue link in the changelog — including other repos' issue numbers. For example, the [23.1.0 release notes](https://github.com/nrwl/nx/releases/tag/23.1.0) contain: > **rspack:** support @rspack/core@2 and @rsbuild/core@2 (multi-version compliance) (#35682, #35764, #13420, #781) where `#13420` is actually `web-infra-dev/rspack#13420` and `#781` is `privatenumber/tsx#781` — upstream issues discussed in the PR description, rendered as (bogus) `nrwl/nx` issue links. The same release also picked up `nrwl/nx-console#3175`, `react/react#418`, and `web-infra-dev/rspack#2292`, plus noisy same-repo PR mentions that were merely referenced in prose. ## Expected Behavior Issue references are only extracted from the commit body when linked via a GitHub closing keyword (`Fixes #123`, `Closes #123`, `Resolves: #123`, ...) — the same rule GitHub itself uses to auto-link and close issues. Cross-repo forms (`owner/repo#123`), markdown links to other repos, and casual same-repo mentions no longer produce changelog references. Subject-line extraction (the PR number in `(#123)` and inline issue refs) is unchanged. Both regular commits and version plans go through the same `extractReferencesFromCommit` function, so this fixes both paths. ## Related Issue(s) N/A <!-- polygraph-session-start --> --- [View session information ↗](https://app.trypolygraph.com/orgs/6a061dcb561c062131116eca/sessions/Fix-nx-release-changelog-scraping-other-repos-issue-numbers-7967dd62) <!-- polygraph-session-end --> (cherry picked from commit d7312d2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revisiting #364 #114
(sorry for the extra pull request - used Github wrong the last time)