Skip to content

[Fiber] Don't set .innerHTML when it hasn't changed#36949

Merged
sophiebits merged 1 commit into
react:mainfrom
sophiebits:gh-30994
Jul 7, 2026
Merged

[Fiber] Don't set .innerHTML when it hasn't changed#36949
sophiebits merged 1 commit into
react:mainfrom
sophiebits:gh-30994

Conversation

@sophiebits

Copy link
Copy Markdown
Collaborator

Fixes #30994. We compared this previously but it regressed in #26501.

@meta-cla meta-cla Bot added the CLA Signed label Jul 7, 2026
@github-actions github-actions Bot added the React Core Team Opened by a member of the React Core Team label Jul 7, 2026
@react-sizebot

react-sizebot commented Jul 7, 2026

Copy link
Copy Markdown

Comparing: fc08d76...07e1090

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 7.19 kB 7.19 kB = 1.91 kB 1.91 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.02% 614.43 kB 614.54 kB +0.02% 108.59 kB 108.61 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 7.19 kB 7.19 kB = 1.91 kB 1.91 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.02% 685.61 kB 685.73 kB +0.01% 120.08 kB 120.10 kB
facebook-www/ReactDOM-prod.classic.js +0.02% 705.96 kB 706.08 kB +0.01% 123.67 kB 123.68 kB
facebook-www/ReactDOM-prod.modern.js +0.02% 696.28 kB 696.39 kB +0.01% 122.05 kB 122.07 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 07e1090

Fixes react#30994. We compared this previously but it regressed in react#26501.
@eps1lon eps1lon changed the title Don't set .innerHTML when it hasn't changed [Fiber] Don't set .innerHTML when it hasn't changed Jul 7, 2026
@sophiebits
sophiebits merged commit b8f50c9 into react:main Jul 7, 2026
238 checks passed
@sophiebits
sophiebits deleted the gh-30994 branch July 7, 2026 16:09
github-actions Bot pushed a commit that referenced this pull request Jul 7, 2026
Fixes #30994. We compared this previously but it regressed in #26501.

DiffTrain build for [b8f50c9](b8f50c9)
github-actions Bot pushed a commit that referenced this pull request Jul 7, 2026
Fixes #30994. We compared this previously but it regressed in #26501.

DiffTrain build for [b8f50c9](b8f50c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[React 19] [bug] SVG with dangerouslySetInnerHTML content does not trigger first click

3 participants