[DevTools] Send root unmount as a regular removal operation#35107
Merged
eps1lon merged 1 commit intoNov 11, 2025
Conversation
github-actions
Bot
added
the
React Core Team
eps1lon
marked this pull request as ready for review
November 11, 2025 10:16
hoxyq
approved these changes
Nov 11, 2025
eps1lon
deleted the
sebbie/11-11-_devtools_send_root_unmount_as_a_regular_removal_operation
branch
November 11, 2025 22:09
This was referenced Nov 12, 2025
manNomi
pushed a commit
to manNomi/react
that referenced
this pull request
Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We explicitly defer unmounting the root until all removal operations have been processed. This requires flushing pending operations before we unmount the next root.
All the other unmount operations already rely on child-first ordering so I don't think we need to special case the root.
This change is required to batch operations when updating the filter where we unmount+mount all roots.