Ship partial-prerendering APIs to Canary#34633
Merged
eps1lon merged 6 commits intoOct 1, 2025
Merged
Conversation
github-actions
Bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/09-28-ship_partial-prerendering_apis_to_canary
branch
4 times, most recently
from
September 28, 2025 16:11
ede8cd4 to
8b2cc91
Compare
All OSS builds have these entrypoints now
eps1lon
force-pushed
the
sebbie/09-28-ship_partial-prerendering_apis_to_canary
branch
from
September 28, 2025 16:13
8b2cc91 to
5bcfccc
Compare
eps1lon
commented
Sep 28, 2025
| result.prelude.pipe(writable); | ||
| }); | ||
| expect(getVisibleChildren(container)).toEqual(undefined); | ||
| expect(errors).toEqual([]); |
Collaborator
Author
There was a problem hiding this comment.
The test used to fail due to prerenderToNodeStream not existing. Since that API exists everywhere now, the only error happens in onError calling console.error(postponedValue). However, we ignore console.error(someErrorInstance) in our testing infra and it would take a while to update all the tests to also assert on prod errors.
In dev the test failed because we also called console.error with the environment name
eps1lon
force-pushed
the
sebbie/09-28-ship_partial-prerendering_apis_to_canary
branch
from
September 28, 2025 16:22
5bcfccc to
5ba4156
Compare
eps1lon
force-pushed
the
sebbie/09-28-ship_partial-prerendering_apis_to_canary
branch
from
September 28, 2025 18:25
5ba4156 to
bdac823
Compare
eps1lon
commented
Sep 29, 2025
Comment on lines
-1592
to
1601
| if (__EXPERIMENTAL__) { | ||
| const useTransitionHelper = () => React.useTransition(); | ||
| const useDeferredValueHelper = () => | ||
| React.useDeferredValue(0, {timeoutMs: 1000}); | ||
| const useTransitionHelper = () => React.useTransition(); | ||
| const useDeferredValueHelper = () => | ||
| React.useDeferredValue(0, {timeoutMs: 1000}); | ||
|
|
||
| orderedHooks.push(useTransitionHelper); | ||
| orderedHooks.push(useDeferredValueHelper); | ||
| orderedHooks.push(useTransitionHelper); | ||
| orderedHooks.push(useDeferredValueHelper); | ||
|
|
||
| hooksInList.push(useTransitionHelper); | ||
| hooksInList.push(useDeferredValueHelper); | ||
| } | ||
| hooksInList.push(useTransitionHelper); | ||
| hooksInList.push(useDeferredValueHelper); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
drive-by fix when looking for things gated on experimental.
eps1lon
marked this pull request as ready for review
September 29, 2025 16:24
sebmarkbage
approved these changes
Oct 1, 2025
eps1lon
deleted the
sebbie/09-28-ship_partial-prerendering_apis_to_canary
branch
October 2, 2025 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also enables these APIs for FB builds.
Docs are work-in-progress.