[DevTools] Always attempt to mount dehydrated roots #34209
Merged
eps1lon merged 1 commit intoAug 16, 2025
Merged
Conversation
eps1lon
changed the title
github-actions
Bot
added
the
React Core Team
eps1lon
commented
Aug 15, 2025
| case TREE_OPERATION_SET_SUBTREE_MODE: { | ||
| const id = operations[i + 1]; | ||
| const mode = operations[i + 1]; | ||
| const mode = operations[i + 2]; |
Collaborator
Author
There was a problem hiding this comment.
I originally thought I messed up operations parsing. Noticed this small mistakes in our debugging tools
eps1lon
marked this pull request as ready for review
August 15, 2025 17:55
sebmarkbage
approved these changes
Aug 15, 2025
eps1lon
force-pushed
the
sebbie/08-15-_devtools_always_attempt_to_mount_dehydrated_roots
branch
from
August 16, 2025 08:28
c6df6bf to
14e4a54
Compare
`mountFiberRecursively` bails out of hydrating dehydrated roots nowadays. This makes the check in `handleCommitFiberRoot` redundant. Mostly doing this because the check in `handleCommitFiberRoot` wasn't mirrored in the initial mount path. `handleCommitFiberRoot` always attempted to mount dehydrated roots when it first encountered a HostRoot. But on updates, it treated a previously dehydrated HostRoot as newly mounted. This resulted in recording mounts twice which is not supported.
eps1lon
force-pushed
the
sebbie/08-15-_devtools_always_attempt_to_mount_dehydrated_roots
branch
from
August 16, 2025 08:38
14e4a54 to
e41609d
Compare
eps1lon
deleted the
sebbie/08-15-_devtools_always_attempt_to_mount_dehydrated_roots
branch
August 16, 2025 09:25
github-actions Bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 17, 2025
DiffTrain build for [546bac7](react@546bac7)
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #34196
mountFiberRecursivelybails out of hydrating dehydrated roots nowadays.This makes the check in
handleCommitFiberRootredundant.Mostly doing this because the check in
handleCommitFiberRootwasn't mirrored in the initial mount path.handleCommitFiberRootalways attempted to mount dehydrated roots when it first encountered a HostRoot. But on updates, it treated a previously dehydrated HostRoot as newly mounted. This resulted in recording mounts twice which is not supported.