Avoid replaying SelectiveHydrationException in dev#25754
Merged
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 7fab379...c8a573b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
acdlite
approved these changes
Dec 1, 2022
tyao1
force-pushed
the
ty-selective-hydration-exception
branch
from
December 2, 2022 19:29
bed17ad to
c8a573b
Compare
tyao1
added a commit
that referenced
this pull request
Dec 15, 2022
This PR includes the previously reverted #25695 and #25754, and the fix for the regression test added in #25867. Tested internally with a previous failed test, and it's passing now. Co-authored-by: Andrew Clark <[email protected]>
github-actions Bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
This PR includes the previously reverted #25695 and #25754, and the fix for the regression test added in #25867. Tested internally with a previous failed test, and it's passing now. Co-authored-by: Andrew Clark <[email protected]> DiffTrain build for [7efa9e5](7efa9e5) [View git log for this commit](https://github.com/facebook/react/commits/7efa9e59707b341f10fab79724e0fca373187925)
facebook-github-bot
pushed a commit
to react/react-native
that referenced
this pull request
Jan 31, 2023
Summary: This sync includes the following changes: - **[48b687f](react/react@48b687fc9 )**: [trusted types][www] Add enableTrustedTypesIntegration flag back in ([#26016](react/react#26016)) //<an onion>// - **[9b1423c](react/react@9b1423cc0 )**: Revert "Hold host functions in var" ([#26079](react/react#26079)) //<Samuel Susla>// - **[ce09ace](react/react@ce09ace9a )**: Improve Error Messages when Access Client References ([#26059](react/react#26059)) //<Sebastian Markbåge>// - **[0652bdb](react/react@0652bdbd1 )**: Add flow types to Maps in ReactNativeViewConfigRegistry.js ([#26064](react/react#26064)) //<Samuel Susla>// - **[ee85098](react/react@ee8509801 )**: [cleanup] remove deletedTreeCleanUpLevel feature flag ([#25529](react/react#25529)) //<Jan Kassens>// - **[0e31dd0](react/react@0e31dd028 )**: Remove findDOMNode www shim ([#25998](react/react#25998)) //<Jan Kassens>// - **[379dd74](react/react@379dd741e )**: [www] set enableTrustedTypesIntegration to false ([#25997](react/react#25997)) //<Jan Kassens>// - **[555ece0](react/react@555ece0cd )**: Don't warn about concurrently rendering contexts if we finished rendering ([#22797](react/react#22797)) //<Sebastian Silbermann>// - **[0fce6bb](react/react@0fce6bb49 )**: [cleanup] remove feature flags warnAboutDefaultPropsOnFunctionComponents and warnAboutStringRefs ([#25980](react/react#25980)) //<Jan Kassens>// - **[7002a67](react/react@7002a6743 )**: [cleanup] remove unused values from ReactFeatureFlags.www-dynamic ([#25575](react/react#25575)) //<Jan Kassens>// - **[a48e54f](react/react@a48e54f2b )**: [cleanup] remove old feature flag warnAboutDeprecatedLifecycles ([#25978](react/react#25978)) //<Jan Kassens>// - **[0f4a835](react/react@0f4a83596 )**: Remove duplicate JSResourceReferenceImpl mock ([#25976](react/react#25976)) //<Jan Kassens>// - **[c491316](react/react@c49131669 )**: Remove unused Flow suppressions ([#25977](react/react#25977)) //<Jan Kassens>// - **[afe6521](react/react@afe6521e1 )**: Refactor: remove useless parameter ([#25923](react/react#25923)) //<Chris>// - **[34464fb](react/react@34464fb16 )**: Upgrade to Flow 0.196.3 ([#25974](react/react#25974)) //<Jan Kassens>// - **[e2424f3](react/react@e2424f33b )**: [flow] enable exact_empty_objects ([#25973](react/react#25973)) //<Jan Kassens>// - **[0b4f443](react/react@0b4f44302 )**: [flow] enable enforce_local_inference_annotations ([#25921](react/react#25921)) //<Jan Kassens>// - **[0b97441](react/react@0b974418c )**: [Fizz] Fork Fizz instruction set for inline script and external runtime ([#25862](react/react#25862)) //<mofeiZ>// - **[5379b61](react/react@5379b6123 )**: Batch sync, default and continuous lanes ([#25700](react/react#25700)) //<Tianyu Yao>// - **[bbf4d22](react/react@bbf4d2211 )**: Update import for babel-code-frame in build script ([#25963](react/react#25963)) //<Ming Ye>// - **[b83baf6](react/react@b83baf63f )**: Transform updates to support Flow this annotation syntax ([#25918](react/react#25918)) //<Jan Kassens>// - **[c2d6552](react/react@c2d655207 )**: Unify `use` and `renderDidSuspendDelayIfPossible` implementations ([#25922](react/react#25922)) //<Andrew Clark>// - **[48274a4](react/react@48274a43a )**: Remove vestigial Suspense batching logic ([#25861](react/react#25861)) //<Andrew Clark>// - **[de7d1c9](react/react@de7d1c907 )**: Add `fetchPriority` to `<img>` and `<link>` ([#25927](react/react#25927)) //<Steven>// - **[81d4ee9](react/react@81d4ee9ca )**: reconciler docs: fix small typo - "mode" (instead of "node") ([#25863](react/react#25863)) //<satelllte>// - **[5fcf1a4](react/react@5fcf1a4b4 )**: Bugfix: Synchronous ping during render phase sometimes unwinds the stack, leading to crash ([#25851](react/react#25851)) //<Andrew Clark>// - **[2b1fb91](react/react@2b1fb91a5 )**: ESLint upgrade to use hermes-eslint ([#25915](react/react#25915)) //<Jan Kassens>// - **[fabef7a](react/react@fabef7a6b )**: Resubmit Add HydrationSyncLane ([#25878](react/react#25878)) //<Tianyu Yao>// - **[7efa9e5](react/react@7efa9e597 )**: Fix unwinding context during selective hydration ([#25876](react/react#25876)) //<Tianyu Yao>// - **[84a0a17](react/react@84a0a171e )**: Rename experimental useEvent to useEffectEvent ([#25881](react/react#25881)) //<Sebastian Markbåge>// - **[4dda96a](react/react@4dda96a40 )**: [react-www] remove forked bundle ([#25866](react/react#25866)) //<Jan Kassens>// - **[9c09c1c](react/react@9c09c1cd6 )**: Revert "Fork ReactDOMSharedInternals for www ([#25791](react/react#25791))" ([#25864](react/react#25864)) //<lauren>// - **[996e4c0](react/react@996e4c0d5 )**: Offscreen add attach ([#25603](react/react#25603)) //<Samuel Susla>// - **[b14d7fa](react/react@b14d7fa4b )**: Add support for setNativeProps to Fabric ([#25737](react/react#25737)) //<Samuel Susla>// - **[8196872](react/react@819687279 )**: [Float] Fix typo in ReactDOMResourceValidation.js ([#25798](react/react#25798)) //<Ikko Ashimine>// - **[5dfc485](react/react@5dfc485f6 )**: fix tests for when float is off ([#25839](react/react#25839)) //<Josh Story>// - **[bfcbf33](react/react@bfcbf3306 )**: toString children of title ([#25838](react/react#25838)) //<Sebastian Markbåge>// - **[d4bc16a](react/react@d4bc16a7d )**: Revert "[react-www] remove forked bundle" ([#25837](react/react#25837)) //<Ricky>// - **[d69b2cf](react/react@d69b2cf82 )**: [bug fix] revert values in ReactFiberFlags to keep consistency for devtools ([#25832](react/react#25832)) //<Mengdi Chen>// - **[645ae26](react/react@645ae2686 )**: [react-www] remove forked bundle ([#25831](react/react#25831)) //<Jan Kassens>// - **[d807eb5](react/react@d807eb52c )**: Revert recent hydration changes ([#25812](react/react#25812)) //<Andrew Clark>// - **[2ccfa65](react/react@2ccfa657d )**: Fork ReactDOMSharedInternals for www ([#25791](react/react#25791)) //<lauren>// - **[f0534ae](react/react@f0534ae94 )**: Avoid replaying SelectiveHydrationException in dev ([#25754](react/react#25754)) //<Tianyu Yao>// - **[7fab379](react/react@7fab379d8 )**: fix link to ReactDOMHostconfig in reconciler docs ([#25788](react/react#25788)) //<Dmitry>// - **[500c8aa](react/react@500c8aa08 )**: Add component name to StrictMode error message ([#25718](react/react#25718)) //<Samuel Susla>// - **[353c302](react/react@353c30252 )**: Hold host functions in var ([#25741](react/react#25741)) //<Samuel Susla>// Changelog: [General][Changed] - React Native sync for revisions 17f6912...48b687f jest_e2e[run_all_tests] Reviewed By: rubennorte Differential Revision: D42855483 fbshipit-source-id: c244a595bb2d490a23b333c1b16d04a459ec94fc
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary This is discovered by @acdlite. In dev we replay errors so debugger will treat them as uncaught errors, but we need to ignore internal exceptions. <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## How did you test this change? manually console.log in some tests, and noticed replay didn't happen. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is discovered by @acdlite.
In dev we replay errors so debugger will treat them as uncaught errors, but we need to ignore internal exceptions.
How did you test this change?
manually console.log in some tests, and noticed replay didn't happen.