Skip to content

Flow: remove max_workers setting#25349

Merged
kassens merged 1 commit into
react:mainfrom
kassens:flow-workers
Sep 29, 2022
Merged

Flow: remove max_workers setting#25349
kassens merged 1 commit into
react:mainfrom
kassens:flow-workers

Conversation

@kassens

@kassens kassens commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

This was added back in #17880 to make CI pass for an unrelated change.

This limits the max worker setting to CI environments as removing the setting completely still seems to break on CircleCI.

This was added back in react#17880 to make CI pass for an unrelated change.

Submitting this PR to see if this is still needed to pass on CI. A lot of things have changed since.

@tyao1 tyao1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@kassens
kassens merged commit abd7bcd into react:main Sep 29, 2022
@kassens
kassens deleted the flow-workers branch September 29, 2022 18:49
rickhanlonii pushed a commit that referenced this pull request Oct 5, 2022
This was added back in #17880 to make CI pass for an unrelated change.

This limits the max worker setting to CI environments as removing the setting completely still seems to break on CircleCI.
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
This was added back in react#17880 to make CI pass for an unrelated change.

This limits the max worker setting to CI environments as removing the setting completely still seems to break on CircleCI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants