Skip to content

Revert "Land enableClientRenderFallbackOnTextMismatch"#24738

Merged
acdlite merged 1 commit into
react:mainfrom
acdlite:revert-text-mismatch-flag
Jun 16, 2022
Merged

Revert "Land enableClientRenderFallbackOnTextMismatch"#24738
acdlite merged 1 commit into
react:mainfrom
acdlite:revert-text-mismatch-flag

Conversation

@acdlite

@acdlite acdlite commented Jun 16, 2022

Copy link
Copy Markdown
Collaborator

This reverts commit 327e4a1.

Turns out we hadn't rolled this out internally yet — I mistook enableClientRenderFallbackOnTextMismatch and thought it said enableClientRenderFallbackOnHydrationMismatch. Need to revert until we finish rolling out the change.

This reverts commit 327e4a1.

Turns out we hadn't rolled this out internally yet — I mistook
enableClientRenderFallbackOnHydrationMismatch for
said enableClientRenderFallbackOnTextMismatch. Need to revert
until we finish rolling out the change.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 16, 2022
@sizebot

sizebot commented Jun 16, 2022

Copy link
Copy Markdown

Comparing: c3d7a7e...ea61fe4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.76 kB 131.76 kB = 42.31 kB 42.31 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 137.03 kB 137.03 kB = 43.90 kB 43.90 kB
facebook-www/ReactDOM-prod.classic.js +0.04% 440.91 kB 441.06 kB +0.06% 80.63 kB 80.67 kB
facebook-www/ReactDOM-prod.modern.js +0.04% 426.21 kB 426.37 kB +0.05% 78.44 kB 78.48 kB
facebook-www/ReactDOMForked-prod.classic.js +0.04% 441.68 kB 441.84 kB +0.06% 80.86 kB 80.91 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactIs-dev.modern.js +1.13% 9.86 kB 9.98 kB +0.98% 2.56 kB 2.58 kB
facebook-www/ReactIs-dev.classic.js +1.13% 9.87 kB 9.98 kB +0.98% 2.56 kB 2.58 kB
facebook-www/ReactFlightDOMRelayClient-dev.modern.js +0.87% 12.83 kB 12.94 kB +0.61% 3.78 kB 3.80 kB
facebook-www/ReactFlightDOMRelayClient-dev.classic.js +0.87% 12.83 kB 12.94 kB +0.58% 3.78 kB 3.80 kB
facebook-www/ReactFreshRuntime-dev.modern.js +0.49% 22.81 kB 22.93 kB +0.36% 6.65 kB 6.67 kB
facebook-www/ReactFreshRuntime-dev.classic.js +0.49% 22.82 kB 22.93 kB +0.36% 6.64 kB 6.67 kB
facebook-www/JSXDEVRuntime-dev.modern.js +0.24% 45.66 kB 45.77 kB +0.20% 12.85 kB 12.88 kB
facebook-www/JSXDEVRuntime-dev.classic.js +0.24% 45.66 kB 45.77 kB +0.21% 12.85 kB 12.88 kB
facebook-www/ReactTestUtils-dev.modern.js +0.22% 49.35 kB 49.46 kB +0.18% 13.82 kB 13.84 kB
facebook-www/ReactTestUtils-dev.classic.js +0.22% 49.35 kB 49.46 kB +0.19% 13.81 kB 13.84 kB
facebook-www/ReactFlightDOMRelayServer-dev.classic.js +0.21% 54.03 kB 54.15 kB +0.18% 13.76 kB 13.79 kB
facebook-www/ReactFlightDOMRelayServer-dev.modern.js +0.21% 54.09 kB 54.20 kB +0.18% 13.78 kB 13.80 kB

Generated by 🚫 dangerJS against ea61fe4

@acdlite
acdlite merged commit 229c86a into react:main Jun 16, 2022
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Aug 17, 2022
Summary:
This sync includes the following changes:
- **[229c86a](react/react@229c86af0 )**: Revert "Land enableClientRenderFallbackOnTextMismatch" ([#24738](react/react#24738)) //<Andrew Clark>//
- **[c3d7a7e](react/react@c3d7a7e3d )**: Bugfix: Offscreen instance is null during setState ([#24734](react/react#24734)) //<Andrew Clark>//
- **[fcd720d](react/react@fcd720d36 )**: [Transition Tracing] Push Transition When Offscreen Becomes Visible ([#24718](react/react#24718)) //<Luna Ruan>//
- **[5cc2487](react/react@5cc2487e0 )**: bump versions for next release ([#24725](react/react#24725)) //<Josh Story>//
- **[54f17e4](react/react@54f17e490 )**: [Transition Tracing] Fix Cache and Transitions Pop Order ([#24719](react/react#24719)) //<Luna Ruan>//
- **[7cf8dfd](react/react@7cf8dfd94 )**: [Transition Tracing] Create/Process Marker Complete Callback ([#24700](react/react#24700)) //<Luna Ruan>//
- **[327e4a1](react/react@327e4a1f9 )**: [Follow-up] Land enableClientRenderFallbackOnTextMismatch //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions a8c9cb1...229c86a

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D38738652

fbshipit-source-id: 35b6b3cbfdbdafc28a356b53af6456aaa1949432
roryabraham pushed a commit to Expensify/react-native that referenced this pull request Aug 17, 2022
Summary:
This sync includes the following changes:
- **[229c86a](react/react@229c86af0 )**: Revert "Land enableClientRenderFallbackOnTextMismatch" ([react#24738](react/react#24738)) //<Andrew Clark>//
- **[c3d7a7e](react/react@c3d7a7e3d )**: Bugfix: Offscreen instance is null during setState ([react#24734](react/react#24734)) //<Andrew Clark>//
- **[fcd720d](react/react@fcd720d36 )**: [Transition Tracing] Push Transition When Offscreen Becomes Visible ([react#24718](react/react#24718)) //<Luna Ruan>//
- **[5cc2487](react/react@5cc2487e0 )**: bump versions for next release ([react#24725](react/react#24725)) //<Josh Story>//
- **[54f17e4](react/react@54f17e490 )**: [Transition Tracing] Fix Cache and Transitions Pop Order ([react#24719](react/react#24719)) //<Luna Ruan>//
- **[7cf8dfd](react/react@7cf8dfd94 )**: [Transition Tracing] Create/Process Marker Complete Callback ([react#24700](react/react#24700)) //<Luna Ruan>//
- **[327e4a1](react/react@327e4a1f9 )**: [Follow-up] Land enableClientRenderFallbackOnTextMismatch //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions a8c9cb1...229c86a

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D38738652

fbshipit-source-id: 35b6b3cbfdbdafc28a356b53af6456aaa1949432
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
This reverts commit 27fc72d.

Turns out we hadn't rolled this out internally yet — I mistook
enableClientRenderFallbackOnHydrationMismatch for
said enableClientRenderFallbackOnTextMismatch. Need to revert
until we finish rolling out the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants