Skip to content

Remove enablePersistentOffscreenHostContainer flag#24460

Merged
acdlite merged 1 commit into
react:mainfrom
acdlite:delete-offscreen-host-container
Apr 28, 2022
Merged

Remove enablePersistentOffscreenHostContainer flag#24460
acdlite merged 1 commit into
react:mainfrom
acdlite:delete-offscreen-host-container

Conversation

@acdlite

@acdlite acdlite commented Apr 28, 2022

Copy link
Copy Markdown
Collaborator

This was a Fabric-related experiment that we ended up not shipping.

This was a Fabric-related experiment that we ended up not shipping.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 28, 2022
@sizebot

sizebot commented Apr 28, 2022

Copy link
Copy Markdown

Comparing: 340060c...06b2aa6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.58 kB 131.58 kB +0.14% 42.11 kB 42.17 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.82 kB 136.82 kB = 43.69 kB 43.68 kB
facebook-www/ReactDOM-prod.classic.js = 441.17 kB 441.21 kB = 80.49 kB 80.36 kB
facebook-www/ReactDOM-prod.modern.js +0.01% 426.38 kB 426.42 kB = 78.29 kB 78.20 kB
facebook-www/ReactDOMForked-prod.classic.js = 441.17 kB 441.21 kB = 80.49 kB 80.36 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js +6.18% 7.09 kB 7.53 kB +12.52% 1.83 kB 2.06 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js = 13.80 kB 12.41 kB = 3.99 kB 3.70 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js = 13.80 kB 12.41 kB = 3.99 kB 3.70 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js = 13.80 kB 12.41 kB = 3.99 kB 3.70 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.min.js = 13.73 kB 12.34 kB = 3.98 kB 3.68 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.min.js = 13.73 kB 12.34 kB = 3.98 kB 3.68 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.min.js = 13.73 kB 12.34 kB = 3.98 kB 3.68 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.51 kB 34.40 kB = 8.98 kB 7.70 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.51 kB 34.40 kB = 8.98 kB 7.70 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.51 kB 34.40 kB = 8.98 kB 7.70 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.38 kB 34.27 kB = 8.97 kB 7.68 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.38 kB 34.27 kB = 8.97 kB 7.68 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.38 kB 34.27 kB = 8.97 kB 7.68 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-is/cjs/ReactIs-dev.js +6.18% 7.09 kB 7.53 kB +12.52% 1.83 kB 2.06 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js +1.24% 35.37 kB 35.81 kB +1.99% 10.18 kB 10.39 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js +1.22% 35.97 kB 36.41 kB +1.95% 10.36 kB 10.56 kB
facebook-react-native/react/cjs/React-dev.js +0.42% 104.65 kB 105.08 kB +0.87% 25.57 kB 25.79 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 816.11 kB 810.73 kB = 177.47 kB 176.04 kB
react-native/implementations/ReactFabric-dev.fb.js = 807.94 kB 800.62 kB = 175.58 kB 173.58 kB
react-native/implementations/ReactFabric-profiling.fb.js = 328.62 kB 323.92 kB = 58.76 kB 57.83 kB
react-native/implementations/ReactFabric-prod.fb.js = 301.50 kB 296.85 kB = 54.53 kB 53.59 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js = 13.80 kB 12.41 kB = 3.99 kB 3.70 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js = 13.80 kB 12.41 kB = 3.99 kB 3.70 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js = 13.80 kB 12.41 kB = 3.99 kB 3.70 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.min.js = 13.73 kB 12.34 kB = 3.98 kB 3.68 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.min.js = 13.73 kB 12.34 kB = 3.98 kB 3.68 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.min.js = 13.73 kB 12.34 kB = 3.98 kB 3.68 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.51 kB 34.40 kB = 8.98 kB 7.70 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.51 kB 34.40 kB = 8.98 kB 7.70 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.51 kB 34.40 kB = 8.98 kB 7.70 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.38 kB 34.27 kB = 8.97 kB 7.68 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.38 kB 34.27 kB = 8.97 kB 7.68 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.38 kB 34.27 kB = 8.97 kB 7.68 kB

Generated by 🚫 dangerJS against 06b2aa6

@acdlite

acdlite commented Apr 28, 2022

Copy link
Copy Markdown
Collaborator Author

facebook-react-native/react-is/cjs/ReactIs-dev.js got slightly bigger because I added a comment in there

@acdlite
acdlite merged commit ce13860 into react:main Apr 28, 2022
eps1lon pushed a commit to eps1lon/react that referenced this pull request Apr 29, 2022
This was a Fabric-related experiment that we ended up not shipping.
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Jun 6, 2022
Summary:
This sync includes the following changes:
- **[dd4950c](react/react@dd4950c90 )**: [Flight] Implement useId hook ([#24172](react/react#24172)) //<Josh Story>//
- **[26a5b3c](react/react@26a5b3c7f )**: Explicitly set `highWaterMark` to 0 for `ReadableStream` ([#24641](react/react#24641)) //<Josh Larson>//
- **[aec5759](react/react@aec575914 )**: [Fizz] Send errors down to client ([#24551](react/react#24551)) //<Josh Story>//
- **[a276638](react/react@a2766387e )**: [Fizz] Improve text separator byte efficiency ([#24630](react/react#24630)) //<Josh Story>//
- **[f786053](react/react@f7860538a )**: Fix typo in useSyncExternalStore main entry point error ([#24631](react/react#24631)) //<François Chalifour>//
- **[1bed207](react/react@1bed20731 )**: Add a module map option to the Webpack Flight Client ([#24629](react/react#24629)) //<Sebastian Markbåge>//
- **[b2763d3](react/react@b2763d3ea )**: Move hydration code out of normal Suspense path ([#24532](react/react#24532)) //<Andrew Clark>//
- **[357a613](react/react@357a61324 )**: [DevTools][Transition Tracing] Added support for Suspense Boundaries ([#23365](react/react#23365)) //<Luna Ruan>//
- **[2c8a145](react/react@2c8a1452b )**: Fix ignored setState in Safari when iframe is touched ([#24459](react/react#24459)) //<dan>//
- **[6266263](react/react@62662633d )**: Remove enableFlipOffscreenUnhideOrder ([#24545](react/react#24545)) //<Ricky>//
- **[34da5aa](react/react@34da5aa69 )**: Only treat updates to lazy as a new mount in legacy mode ([#24530](react/react#24530)) //<Ricky>//
- **[46a6d77](react/react@46a6d77e3 )**: Unify JSResourceReference Interfaces ([#24507](react/react#24507)) //<Timothy Yung>//
- **[6cbf0f7](react/react@6cbf0f7fa )**: Fork ReactSymbols ([#24484](react/react#24484)) //<Ricky>//
- **[a10a9a6](react/react@a10a9a6b5 )**: Add test for hiding children after layout destroy ([#24483](react/react#24483)) //<Ricky>//
- **[b4eb0ad](react/react@b4eb0ad71 )**: Do not replay erroring beginWork with invokeGuardedCallback when suspended or previously errored ([#24480](react/react#24480)) //<Josh Story>//
- **[99eef9e](react/react@99eef9e2d )**: Hide children of Offscreen after destroy effects ([#24446](react/react#24446)) //<Ricky>//
- **[ce13860](react/react@ce1386028 )**: Remove enablePersistentOffscreenHostContainer flag ([#24460](react/react#24460)) //<Andrew Clark>//
- **[72b7462](react/react@72b7462fe )**: Bump local package.json versions for 18.1 release ([#24447](react/react#24447)) //<Andrew Clark>//
- **[22edb9f](react/react@22edb9f77 )**: React `version` field should match package.json ([#24445](react/react#24445)) //<Andrew Clark>//
- **[6bf3dee](react/react@6bf3deef5 )**: Upgrade react-shallow-renderer to support react 18 ([#24442](react/react#24442)) //<Michael サイトー 中村 Bashurov>//

Changelog:
[General][Changed] - React Native sync for revisions bd4784c...d300ceb

jest_e2e[run_all_tests]

Reviewed By: cortinico, kacieb

Differential Revision: D36874368

fbshipit-source-id: c0ee015f4ef2fa56e57f7a1f6bc37dd05c949877
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
This was a Fabric-related experiment that we ended up not shipping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants