Skip to content

Update error message for suspending at sync priority#23361

Merged
acdlite merged 1 commit into
react:mainfrom
acdlite:update-uncaught-suspense-error
Feb 25, 2022
Merged

Update error message for suspending at sync priority#23361
acdlite merged 1 commit into
react:mainfrom
acdlite:update-uncaught-suspense-error

Conversation

@acdlite

@acdlite acdlite commented Feb 25, 2022

Copy link
Copy Markdown
Collaborator

Instead of adding a new Suspense boundary, the default recommendation is to wrap the suspending update with startTransition.

@acdlite
Update error message for suspending at sync priority
a77698d 
Instead of adding a new Suspense boundary, the default recommendation
is to wrap the suspending update with startTransition.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 25, 2022
@sizebot

sizebot commented Feb 25, 2022

Copy link
Copy Markdown

Comparing: 8d0d0e9...a77698d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.35 kB 131.32 kB = 42.02 kB 42.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.17 kB 136.14 kB = 43.44 kB 43.43 kB
facebook-www/ReactDOM-prod.classic.js = 434.44 kB 434.30 kB = 79.45 kB 79.41 kB
facebook-www/ReactDOM-prod.modern.js = 424.23 kB 421.04 kB = 78.01 kB 77.40 kB
facebook-www/ReactDOMForked-prod.classic.js = 434.44 kB 434.30 kB = 79.45 kB 79.42 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMTesting-prod.modern.js = 412.48 kB 410.97 kB = 77.65 kB 77.40 kB
facebook-www/ReactDOM-profiling.modern.js = 454.87 kB 451.68 kB = 82.58 kB 81.98 kB
facebook-www/ReactDOMForked-profiling.modern.js = 454.87 kB 451.68 kB = 82.59 kB 81.98 kB
facebook-www/ReactDOM-prod.modern.js = 424.23 kB 421.04 kB = 78.01 kB 77.40 kB
facebook-www/ReactDOMForked-prod.modern.js = 424.23 kB 421.04 kB = 78.01 kB 77.41 kB
facebook-www/ReactART-prod.modern.js = 270.24 kB 267.05 kB = 48.05 kB 47.48 kB

Generated by 🚫 dangerJS against a77698d

@acdlite
acdlite merged commit 3a60844 into react:main Feb 25, 2022
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Mar 1, 2022
@kacieb @facebook-github-bot
React Native sync for revisions 4de99b3...1780659
6a4e905 
Summary:
This sync includes the following changes:
- **[1780659](react/react@17806594c )**: Move createRoot/hydrateRoot to react-dom/client ([#23385](react/react#23385)) //<Sebastian Markbåge>//
- **[75662d6](react/react@75662d6a7 )**: Remove hacky stream.locked check, declare as byte stream instead ([#23387](react/react#23387)) //<Sebastian Markbåge>//
- **[a82ef6d](react/react@a82ef6d40 )**: Add back skipUnmountedBoundaries flag only for www ([#23383](react/react#23383)) //<Andrew Clark>//
- **[f468816](react/react@f468816ef )**: Fix false positive hydration warnings ([#23364](react/react#23364)) //<Andrew Clark>//
- **[5d08a24](react/react@5d08a24c2 )**: useId: Use 'H' to separate main id from hook index ([#23363](react/react#23363)) //<Andrew Clark>//
- **[3a60844](react/react@3a60844a0 )**: Update error message for suspending at sync priority ([#23361](react/react#23361)) //<Andrew Clark>//
- **[efe4121](react/react@efe4121ee )**: Add : to beginning and end of every useId ([#23360](react/react#23360)) //<Andrew Clark>//
- **[42f15b3](react/react@42f15b324 )**: [DevTools][Transition Tracing] onTransitionComplete and onTransitionStart implmentation ([#23313](react/react#23313)) //<Luna Ruan>//
- **[a5b2215](react/react@a5b22155c )**: Warn if renderSubtreeIntoContainer is called ([#23355](react/react#23355)) //<Andrew Clark>//
- **[52c393b](react/react@52c393b5d )**: Revert to client render on text mismatch ([#23354](react/react#23354)) //<Andrew Clark>//
- **[1ad8d81](react/react@1ad8d8129 )**: Remove object-assign polyfill ([#23351](react/react#23351)) //<Sebastian Markbåge>//
- **[b3f3da2](react/react@b3f3da205 )**: Land warnOnSubscriptionInsideStartTransition flag ([#23353](react/react#23353)) //<Andrew Clark>//
- **[990098f](react/react@990098f88 )**: Re-arrange main ReactFeatureFlags module ([#23350](react/react#23350)) //<Andrew Clark>//
- **[1f3f6db](react/react@1f3f6db73 )**: Remove createMutableSource from stable exports ([#23352](react/react#23352)) //<Andrew Clark>//
- **[587e759](react/react@587e75930 )**: Remove Numeric Fallback of Symbols ([#23348](react/react#23348)) //<Sebastian Markbåge>//
- **[4035157](react/react@40351575d )**: Split writeChunk into void and return value ([#23343](react/react#23343)) //<Sebastian Markbåge>//
- **[2c693b2](react/react@2c693b2de )**: Re-add reentrancy avoidance ([#23342](react/react#23342)) //<Sebastian Markbåge>//
- **[1760b27](react/react@1760b27c0 )**: Remove ./src/* export from public build ([#23262](react/react#23262)) //<Andrew Clark>//
- **[552c067](react/react@552c067bb )**: Remove public export for unstable-shared-subset.js ([#23261](react/react#23261)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions 4de99b3...1780659

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D34552175

fbshipit-source-id: f1c831a45f96d335a20c3b4113196e0a42cefc03
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
@acdlite @zhengjitf
Update error message for suspending at sync priority (react#23361)
f57a4f5 
Instead of adding a new Suspense boundary, the default recommendation
is to wrap the suspending update with startTransition.
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
@kacieb @Saadnajmi
React Native sync for revisions 4de99b3...1780659
cde01ad 
Summary:
This sync includes the following changes:
- **[1780659](react/react@17806594c )**: Move createRoot/hydrateRoot to react-dom/client ([react#23385](react/react#23385)) //<Sebastian Markbåge>//
- **[75662d6](react/react@75662d6a7 )**: Remove hacky stream.locked check, declare as byte stream instead ([react#23387](react/react#23387)) //<Sebastian Markbåge>//
- **[a82ef6d](react/react@a82ef6d40 )**: Add back skipUnmountedBoundaries flag only for www ([react#23383](react/react#23383)) //<Andrew Clark>//
- **[f468816](react/react@f468816ef )**: Fix false positive hydration warnings ([react#23364](react/react#23364)) //<Andrew Clark>//
- **[5d08a24](react/react@5d08a24c2 )**: useId: Use 'H' to separate main id from hook index ([react#23363](react/react#23363)) //<Andrew Clark>//
- **[3a60844](react/react@3a60844a0 )**: Update error message for suspending at sync priority ([react#23361](react/react#23361)) //<Andrew Clark>//
- **[efe4121](react/react@efe4121ee )**: Add : to beginning and end of every useId ([react#23360](react/react#23360)) //<Andrew Clark>//
- **[42f15b3](react/react@42f15b324 )**: [DevTools][Transition Tracing] onTransitionComplete and onTransitionStart implmentation ([react#23313](react/react#23313)) //<Luna Ruan>//
- **[a5b2215](react/react@a5b22155c )**: Warn if renderSubtreeIntoContainer is called ([react#23355](react/react#23355)) //<Andrew Clark>//
- **[52c393b](react/react@52c393b5d )**: Revert to client render on text mismatch ([react#23354](react/react#23354)) //<Andrew Clark>//
- **[1ad8d81](react/react@1ad8d8129 )**: Remove object-assign polyfill ([react#23351](react/react#23351)) //<Sebastian Markbåge>//
- **[b3f3da2](react/react@b3f3da205 )**: Land warnOnSubscriptionInsideStartTransition flag ([react#23353](react/react#23353)) //<Andrew Clark>//
- **[990098f](react/react@990098f88 )**: Re-arrange main ReactFeatureFlags module ([react#23350](react/react#23350)) //<Andrew Clark>//
- **[1f3f6db](react/react@1f3f6db73 )**: Remove createMutableSource from stable exports ([react#23352](react/react#23352)) //<Andrew Clark>//
- **[587e759](react/react@587e75930 )**: Remove Numeric Fallback of Symbols ([react#23348](react/react#23348)) //<Sebastian Markbåge>//
- **[4035157](react/react@40351575d )**: Split writeChunk into void and return value ([react#23343](react/react#23343)) //<Sebastian Markbåge>//
- **[2c693b2](react/react@2c693b2de )**: Re-add reentrancy avoidance ([react#23342](react/react#23342)) //<Sebastian Markbåge>//
- **[1760b27](react/react@1760b27c0 )**: Remove ./src/* export from public build ([react#23262](react/react#23262)) //<Andrew Clark>//
- **[552c067](react/react@552c067bb )**: Remove public export for unstable-shared-subset.js ([react#23261](react/react#23261)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions 4de99b3...1780659

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D34552175

fbshipit-source-id: f1c831a45f96d335a20c3b4113196e0a42cefc03
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
@acdlite
Update error message for suspending at sync priority (react#23361)
28e17be 
Instead of adding a new Suspense boundary, the default recommendation
is to wrap the suspending update with startTransition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@salazarm salazarm salazarm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@acdlite @sizebot @salazarm @facebook-github-bot