Skip to content

[Devtools][Transition Tracing] Add Transition callbacks to createRoot#23276

Merged
lunaruan merged 1 commit into
react:mainfrom
lunaruan:transition_callbacks
Feb 11, 2022
Merged

[Devtools][Transition Tracing] Add Transition callbacks to createRoot#23276
lunaruan merged 1 commit into
react:mainfrom
lunaruan:transition_callbacks

Conversation

@lunaruan

Copy link
Copy Markdown
Contributor
  • Add the type of transition tracing callbacks
  • Add transition tracing callbacks as an option to createRoot
  • Add transition tracing callbacks on the root
  • Add option to pass transition tracing callbacks to createReactNoop

For context within the larger PR see #23103

@lunaruan
lunaruan requested a review from acdlite February 11, 2022 01:39
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 11, 2022
@lunaruan
lunaruan force-pushed the transition_callbacks branch 2 times, most recently from 2b72fa7 to 16974f0 Compare February 11, 2022 01:44
@sizebot

sizebot commented Feb 11, 2022

Copy link
Copy Markdown

Comparing: a6987be...bbcdbf8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 130.59 kB 130.59 kB = 41.86 kB 41.85 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 135.77 kB 135.77 kB = 43.41 kB 43.41 kB
facebook-www/ReactDOM-prod.classic.js = 432.26 kB 432.26 kB = 79.27 kB 79.27 kB
facebook-www/ReactDOM-prod.modern.js = 422.15 kB 422.15 kB = 77.82 kB 77.82 kB
facebook-www/ReactDOMForked-prod.classic.js = 432.26 kB 432.26 kB = 79.28 kB 79.28 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.39% 13.76 kB 13.82 kB +1.41% 3.97 kB 4.03 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.39% 13.76 kB 13.82 kB +1.41% 3.97 kB 4.03 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.39% 13.76 kB 13.82 kB +1.41% 3.97 kB 4.03 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.38% 13.83 kB 13.88 kB +1.38% 3.99 kB 4.04 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.38% 13.83 kB 13.88 kB +1.38% 3.99 kB 4.04 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.38% 13.83 kB 13.88 kB +1.38% 3.99 kB 4.04 kB

Generated by 🚫 dangerJS against bbcdbf8

@acdlite

acdlite commented Feb 11, 2022

Copy link
Copy Markdown
Collaborator

Looks like some files are out of sync, so I'll wait until the tests are passing before leaving a review

@lunaruan
lunaruan force-pushed the transition_callbacks branch 2 times, most recently from 7ea33aa to b339f09 Compare February 11, 2022 17:58
- Add the type of transition tracing callbacks
- Add transition tracing callbacks as an option to `createRoot`
- Add transition tracing callbacks on the root
- Add option to pass transition tracing callbacks to createReactNoop
@lunaruan
lunaruan force-pushed the transition_callbacks branch from b339f09 to bbcdbf8 Compare February 11, 2022 18:04
@lunaruan
lunaruan merged commit 1fb0d06 into react:main Feb 11, 2022
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Feb 17, 2022
Summary:
This sync includes the following changes:
- **[27b5699](react/react@27b569969 )**: Simplify cache pool contexts ([#23280](react/react#23280)) //<Andrew Clark>//
- **[1fb0d06](react/react@1fb0d0687 )**: [Devtools][Transition Tracing] Add Transition callbacks to createRoot ([#23276](react/react#23276)) //<Luna Ruan>//
- **[a6987be](react/react@a6987bee7 )**: add <TracingMarker> component boilerplate ([#23275](react/react#23275)) //<Luna Ruan>//
- **[796fff5](react/react@796fff548 )**: Allow suspending outside a Suspense boundary ([#23267](react/react#23267)) //<Andrew Clark>//
- **[64223fe](react/react@64223fed8 )**: Fix: Multiple hydration errors in same render ([#23273](react/react#23273)) //<Andrew Clark>//
- **[efd8f64](react/react@efd8f6442 )**: Resolve default onRecoverableError at root init ([#23264](react/react#23264)) //<Andrew Clark>//
- **[e0af1aa](react/react@e0af1aabe )**: Fix wrong context argument to `apply` //<Andrew Clark>//
- **[9b5e051](react/react@9b5e0517b )**: Remove deprecated wildcard folder mapping ([#23256](react/react#23256)) //<Andrew Clark>//
- **[274b9fb](react/react@274b9fb16 )**: Remove path resolution from internal forks plugin ([#23255](react/react#23255)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions a3bde79...27b5699

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii, kacieb

Differential Revision: D34241986

fbshipit-source-id: f6ab62df2a918728864283b4f13201275eb3b8a3
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
…react#23276)

- Add the type of transition tracing callbacks
- Add transition tracing callbacks as an option to `createRoot`
- Add transition tracing callbacks on the root
- Add option to pass transition tracing callbacks to createReactNoop
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
Summary:
This sync includes the following changes:
- **[27b5699](react/react@27b569969 )**: Simplify cache pool contexts ([react#23280](react/react#23280)) //<Andrew Clark>//
- **[1fb0d06](react/react@1fb0d0687 )**: [Devtools][Transition Tracing] Add Transition callbacks to createRoot ([react#23276](react/react#23276)) //<Luna Ruan>//
- **[a6987be](react/react@a6987bee7 )**: add <TracingMarker> component boilerplate ([react#23275](react/react#23275)) //<Luna Ruan>//
- **[796fff5](react/react@796fff548 )**: Allow suspending outside a Suspense boundary ([react#23267](react/react#23267)) //<Andrew Clark>//
- **[64223fe](react/react@64223fed8 )**: Fix: Multiple hydration errors in same render ([react#23273](react/react#23273)) //<Andrew Clark>//
- **[efd8f64](react/react@efd8f6442 )**: Resolve default onRecoverableError at root init ([react#23264](react/react#23264)) //<Andrew Clark>//
- **[e0af1aa](react/react@e0af1aabe )**: Fix wrong context argument to `apply` //<Andrew Clark>//
- **[9b5e051](react/react@9b5e0517b )**: Remove deprecated wildcard folder mapping ([react#23256](react/react#23256)) //<Andrew Clark>//
- **[274b9fb](react/react@274b9fb16 )**: Remove path resolution from internal forks plugin ([react#23255](react/react#23255)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions a3bde79...27b5699

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii, kacieb

Differential Revision: D34241986

fbshipit-source-id: f6ab62df2a918728864283b4f13201275eb3b8a3
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
…react#23276)

- Add the type of transition tracing callbacks
- Add transition tracing callbacks as an option to `createRoot`
- Add transition tracing callbacks on the root
- Add option to pass transition tracing callbacks to createReactNoop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants