[Fizz/Flight] Don't use default args#21681
Merged
Merged
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: bd45ad0...77f4e2e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
The closures prevent inlining otherwise.
gaearon
approved these changes
Jun 14, 2021
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
* Don't use default args * Hoist out creation for better inlining The closures prevent inlining otherwise.
facebook-github-bot
pushed a commit
to react/react-native
that referenced
this pull request
Jun 22, 2021
Summary: This sync includes the following changes: - **[43f4cc1](react/react@43f4cc160 )**: Fix failing test ([#21697](react/react#21697)) //<Dan Abramov>// - **[d0f348d](react/react@d0f348dc1 )**: Fix for failed Suspense layout semantics ([#21694](react/react#21694)) //<Brian Vaughn>// - **[bd0a963](react/react@bd0a96344 )**: Throw when `act` is used in production ([#21686](react/react#21686)) //<Andrew Clark>// - **[9343f87](react/react@9343f8720 )**: Use the server src files as entry points for the builds/tests ([#21683](react/react#21683)) //<Sebastian Markbåge>// - **[502f8a2](react/react@502f8a2a0 )**: [Fizz/Flight] Don't use default args ([#21681](react/react#21681)) //<Sebastian Markbåge>// - **[a8f5e77](react/react@a8f5e77b9 )**: Remove invokeGuardedCallback from commit phase ([#21666](react/react#21666)) //<Dan Abramov>// - **[dbe3363](react/react@dbe3363cc )**: [Fizz] Implement Legacy renderToString and renderToNodeStream on top of Fizz ([#21276](react/react#21276)) //<Sebastian Markbåge>// - **[101ea9f](react/react@101ea9f55 )**: Set deletedTreeCleanUpLevel to 3 ([#21679](react/react#21679)) //<Dan Abramov>// - **[1a106bd](react/react@1a106bdc2 )**: Wrap eventhandle-specific logic in a flag ([#21657](react/react#21657)) //<Dan Abramov>// - **[cb30388](react/react@cb30388d1 )**: Export React Native `AttributeType` Types ([#21661](react/react#21661)) //<Timothy Yung>// - **[c153679](react/react@c1536795c )**: Revert "Make enableSuspenseLayoutEffectSemantics static for www ([#21617](react/react#21617))" ([#21656](react/react#21656)) //<Sebastian Markbåge>// Changelog: [General][Changed] - React Native sync for revisions c96b78e...568dc35 jest_e2e[run_all_tests] Reviewed By: rickhanlonii Differential Revision: D29303157 fbshipit-source-id: 90952885eb2264f4effa04070357b80700bb9be3
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
* Don't use default args * Hoist out creation for better inlining The closures prevent inlining otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These don't compile very nicely because they end up checking the argument length instead of undefinedness for some reason.