Skip to content

Add a test for non-passive event handlers for events affected by the browsers' intervention#19658

Merged
gaearon merged 1 commit into
react:masterfrom
koba04:add-test-for-non-passive-event-handlers
Aug 24, 2020
Merged

Add a test for non-passive event handlers for events affected by the browsers' intervention#19658
gaearon merged 1 commit into
react:masterfrom
koba04:add-test-for-non-passive-event-handlers

Conversation

@koba04

@koba04 koba04 commented Aug 20, 2020

Copy link
Copy Markdown
Contributor

Summary

This adds a test @trueadm has commented at #19654 (comment).
The test ensures that unstable_createEventHandle isn't affected by browsers' intervention #19654 mentioned.

Test Plan

@koba04 koba04 mentioned this pull request Aug 20, 2020
Merged
@codesandbox-ci

codesandbox-ci Bot commented Aug 20, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7044514:

Sandbox Source
React Configuration

@koba04
koba04 force-pushed the add-test-for-non-passive-event-handlers branch 3 times, most recently from 05a0986 to 60bfae7 Compare August 20, 2020 02:28
@koba04

koba04 commented Aug 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

My CircleCI builds are blocked and didn't run all builds I expect.. I'm not sure why this happens, so I have to investigate it.
https://app.circleci.com/pipelines/github/koba04/react?branch=add-test-for-non-passive-event-handlers

@koba04

koba04 commented Aug 20, 2020

Copy link
Copy Markdown
Contributor Author

image

@koba04

koba04 commented Aug 20, 2020

Copy link
Copy Markdown
Contributor Author

I've posted the issue on CircleCI's discuss.
https://discuss.circleci.com/t/builds-for-facebook-react-are-blocked-due-to-parallelism/37139

@koba04
koba04 force-pushed the add-test-for-non-passive-event-handlers branch from 60bfae7 to c14ed86 Compare August 20, 2020 10:09
@koba04

koba04 commented Aug 20, 2020

Copy link
Copy Markdown
Contributor Author

OK, I've fixed the problem, so this PR is ready for review.

@sizebot

sizebot commented Aug 20, 2020 •
edited
Loading

Copy link
Copy Markdown

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 7044514

@sizebot

sizebot commented Aug 20, 2020 •
edited
Loading

Copy link
Copy Markdown

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 7044514

@koba04
koba04 force-pushed the add-test-for-non-passive-event-handlers branch from c14ed86 to 7044514 Compare August 20, 2020 11:17
@gaearon
gaearon merged commit 2ada4bd into react:master Aug 24, 2020
@gaearon

gaearon commented Aug 24, 2020

Copy link
Copy Markdown
Collaborator

thx

@koba04
koba04 deleted the add-test-for-non-passive-event-handlers branch August 24, 2020 14:04
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
@koba04 @koto
Add a test for non-passive event handlers for events affected by the …
5ae9353 
…browsers' intervention (react#19658)
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
@koba04
Add a test for non-passive event handlers for events affected by the …
f8511a6 
…browsers' intervention (react#19658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koba04 @sizebot @gaearon @facebook-github-bot