Remove unused arguments in the reconciler by gaearon · Pull Request #18092 · react/react

gaearon · 2020-02-21T01:37:16Z

Rollup found these: https://github.com/kunukn/reactjs-rollup-upgrade/compare/299034..7441bc

Can remove?

sizebot · 2020-02-21T01:45:01Z

Details of bundled changes.

Comparing: 3b3decf...3f72f8d

react-native-renderer

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
ReactFabric-dev.js	-0.1%	-0.1%	741.5 KB	740.7 KB	155.7 KB	155.62 KB	RN_OSS_DEV
ReactFabric-prod.js	-0.3%	-0.1%	267.01 KB	266.33 KB	45.83 KB	45.77 KB	RN_OSS_PROD
ReactNativeRenderer-dev.js	-0.1%	-0.0%	750.88 KB	750.08 KB	157.9 KB	157.82 KB	RN_OSS_DEV
ReactFabric-profiling.js	-0.3%	-0.1%	278.15 KB	277.42 KB	47.96 KB	47.91 KB	RN_OSS_PROFILING
ReactNativeRenderer-prod.js	-0.3%	-0.1%	274.58 KB	273.9 KB	47.08 KB	47.04 KB	RN_OSS_PROD
ReactNativeRenderer-profiling.js	-0.3%	-0.1%	285.77 KB	285.04 KB	49.23 KB	49.18 KB	RN_OSS_PROFILING

react-reconciler

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-reconciler-persistent.production.min.js	-0.1%	-0.1%	72.52 KB	72.44 KB	21.31 KB	21.28 KB	NODE_PROD
react-reconciler.development.js	-0.1%	-0.0%	609.66 KB	609.17 KB	127.65 KB	127.63 KB	NODE_DEV
react-reconciler.production.min.js	-0.1%	-0.1%	72.51 KB	72.43 KB	21.31 KB	21.28 KB	NODE_PROD
react-reconciler-reflection.development.js	0.0%	0.0%	19.51 KB	19.51 KB	6.39 KB	6.39 KB	NODE_DEV
react-reconciler-reflection.production.min.js	0.0%	🔺+0.1%	2.85 KB	2.85 KB	1.24 KB	1.24 KB	NODE_PROD
react-reconciler-persistent.development.js	-0.1%	-0.0%	606.85 KB	606.37 KB	126.47 KB	126.45 KB	NODE_DEV

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom-test-utils.development.js	0.0%	0.0%	53.02 KB	53.02 KB	15.06 KB	15.06 KB	NODE_DEV
react-dom.production.min.js	-0.1%	-0.1%	115.84 KB	115.75 KB	37.26 KB	37.22 KB	UMD_PROD
react-dom-unstable-native-dependencies.development.js	0.0%	0.0%	60.59 KB	60.59 KB	15.99 KB	15.99 KB	NODE_DEV
react-dom.profiling.min.js	-0.1%	-0.0%	119.46 KB	119.37 KB	38.41 KB	38.39 KB	UMD_PROFILING
react-dom-unstable-native-dependencies.production.min.js	0.0%	0.0%	9.96 KB	9.96 KB	3.36 KB	3.36 KB	NODE_PROD
react-dom.development.js	-0.1%	-0.0%	951.36 KB	950.88 KB	213.4 KB	213.37 KB	NODE_DEV
react-dom.production.min.js	-0.1%	-0.0%	115.91 KB	115.83 KB	36.61 KB	36.59 KB	NODE_PROD
react-dom.profiling.min.js	-0.1%	-0.0%	119.68 KB	119.59 KB	37.72 KB	37.7 KB	NODE_PROFILING
react-dom-unstable-fizz.browser.production.min.js	0.0%	🔺+0.1%	1.2 KB	1.2 KB	702 B	703 B	UMD_PROD
react-dom-server.browser.development.js	0.0%	0.0%	137.96 KB	137.96 KB	36.67 KB	36.67 KB	UMD_DEV
react-dom-server.browser.production.min.js	0.0%	0.0%	20.01 KB	20.01 KB	7.41 KB	7.41 KB	UMD_PROD
react-dom-unstable-fizz.browser.development.js	0.0%	+0.1%	3.7 KB	3.7 KB	1.49 KB	1.5 KB	NODE_DEV
react-dom-test-utils.development.js	0.0%	0.0%	54.74 KB	54.74 KB	15.38 KB	15.38 KB	UMD_DEV
react-dom-unstable-fizz.browser.production.min.js	0.0%	🔺+0.2%	1.04 KB	1.04 KB	633 B	634 B	NODE_PROD
react-dom-server.browser.development.js	0.0%	0.0%	133.9 KB	133.9 KB	35.65 KB	35.65 KB	NODE_DEV
react-dom-unstable-fizz.node.development.js	0.0%	+0.1%	4.4 KB	4.4 KB	1.64 KB	1.64 KB	NODE_DEV
react-dom-unstable-native-dependencies.development.js	0.0%	0.0%	60.89 KB	60.89 KB	16.06 KB	16.07 KB	UMD_DEV
react-dom-unstable-fizz.node.production.min.js	0.0%	🔺+0.1%	1.2 KB	1.2 KB	688 B	689 B	NODE_PROD
react-dom-unstable-native-dependencies.production.min.js	0.0%	0.0%	10.22 KB	10.22 KB	3.47 KB	3.47 KB	UMD_PROD
react-dom-server.node.development.js	0.0%	0.0%	135.01 KB	135.01 KB	35.88 KB	35.88 KB	NODE_DEV
react-dom.development.js	-0.1%	-0.0%	957.3 KB	956.82 KB	215.1 KB	215.08 KB	UMD_DEV

react-art

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-art.production.min.js	-0.1%	-0.1%	104.77 KB	104.67 KB	31.83 KB	31.81 KB	UMD_PROD
react-art.development.js	-0.1%	-0.0%	677.96 KB	677.48 KB	145.9 KB	145.87 KB	UMD_DEV
react-art.development.js	-0.1%	-0.0%	608.64 KB	608.16 KB	128.48 KB	128.46 KB	NODE_DEV
react-art.production.min.js	-0.1%	-0.0%	69.77 KB	69.68 KB	21 KB	20.99 KB	NODE_PROD

react-test-renderer

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-test-renderer-shallow.development.js	0.0%	0.0%	37.81 KB	37.81 KB	9.8 KB	9.8 KB	UMD_DEV
react-test-renderer-shallow.production.min.js	0.0%	0.0%	11.64 KB	11.64 KB	3.59 KB	3.59 KB	UMD_PROD
react-test-renderer-shallow.development.js	0.0%	0.0%	32.35 KB	32.35 KB	8.49 KB	8.49 KB	NODE_DEV
react-test-renderer-shallow.production.min.js	0.0%	🔺+0.1%	11.78 KB	11.78 KB	3.7 KB	3.7 KB	NODE_PROD
react-test-renderer.development.js	-0.1%	-0.0%	622.74 KB	622.25 KB	131.43 KB	131.41 KB	UMD_DEV
react-test-renderer.production.min.js	-0.1%	0.0%	71.91 KB	71.81 KB	21.92 KB	21.92 KB	UMD_PROD
react-test-renderer.development.js	-0.1%	-0.0%	618 KB	617.52 KB	130.25 KB	130.23 KB	NODE_DEV
react-test-renderer.production.min.js	-0.1%	-0.1%	71.61 KB	71.52 KB	21.54 KB	21.53 KB	NODE_PROD

ReactDOM: size: -0.1%, gzip: -0.1%

Size changes (stable)

Generated by 🚫 dangerJS against 3f72f8d

sizebot · 2020-02-21T01:46:29Z

Details of bundled changes.

Comparing: 3b3decf...3f72f8d

react-test-renderer

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-test-renderer.development.js	-0.1%	-0.0%	622.76 KB	622.28 KB	131.44 KB	131.42 KB	UMD_DEV
react-test-renderer.production.min.js	-0.1%	0.0%	71.93 KB	71.84 KB	21.94 KB	21.94 KB	UMD_PROD
react-test-renderer-shallow.development.js	0.0%	0.0%	37.83 KB	37.83 KB	9.81 KB	9.81 KB	UMD_DEV
react-test-renderer-shallow.production.min.js	0.0%	0.0%	11.66 KB	11.66 KB	3.6 KB	3.6 KB	UMD_PROD
react-test-renderer-shallow.development.js	0.0%	0.0%	32.37 KB	32.37 KB	8.5 KB	8.5 KB	NODE_DEV
react-test-renderer-shallow.production.min.js	0.0%	🔺+0.1%	11.79 KB	11.79 KB	3.71 KB	3.71 KB	NODE_PROD
react-test-renderer.development.js	-0.1%	-0.0%	618.03 KB	617.54 KB	130.26 KB	130.25 KB	NODE_DEV
react-test-renderer.production.min.js	-0.1%	-0.1%	71.63 KB	71.55 KB	21.56 KB	21.54 KB	NODE_PROD
ReactTestRenderer-dev.js	-0.1%	-0.1%	633.91 KB	633.11 KB	131.1 KB	131.02 KB	FB_WWW_DEV

react-native-renderer

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
ReactNativeRenderer-dev.js	-0.1%	-0.0%	750.89 KB	750.09 KB	157.91 KB	157.83 KB	RN_OSS_DEV
ReactFabric-dev.js	-0.1%	-0.1%	741.51 KB	740.71 KB	155.7 KB	155.62 KB	RN_OSS_DEV
ReactNativeRenderer-dev.js	-0.1%	-0.1%	751.07 KB	750.27 KB	158 KB	157.92 KB	RN_FB_DEV
ReactFabric-prod.js	-0.3%	-0.1%	267.02 KB	266.34 KB	45.83 KB	45.78 KB	RN_OSS_PROD
ReactNativeRenderer-prod.js	-0.2%	-0.1%	274.99 KB	274.3 KB	47.16 KB	47.12 KB	RN_FB_PROD
ReactFabric-profiling.js	-0.3%	-0.1%	278.16 KB	277.43 KB	47.97 KB	47.92 KB	RN_OSS_PROFILING
ReactNativeRenderer-profiling.js	-0.3%	-0.1%	286.16 KB	285.44 KB	49.31 KB	49.26 KB	RN_FB_PROFILING
ReactNativeRenderer-prod.js	-0.3%	-0.1%	274.6 KB	273.91 KB	47.09 KB	47.05 KB	RN_OSS_PROD
ReactFabric-dev.js	-0.1%	-0.1%	741.69 KB	740.89 KB	155.79 KB	155.71 KB	RN_FB_DEV
ReactNativeRenderer-profiling.js	-0.3%	-0.1%	285.78 KB	285.05 KB	49.24 KB	49.19 KB	RN_OSS_PROFILING
ReactFabric-prod.js	-0.3%	-0.1%	267.37 KB	266.69 KB	45.9 KB	45.85 KB	RN_FB_PROD
ReactFabric-profiling.js	-0.3%	-0.1%	278.51 KB	277.78 KB	48.03 KB	47.98 KB	RN_FB_PROFILING

react-art

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
ReactART-dev.js	-0.1%	-0.1%	622.23 KB	621.43 KB	128.54 KB	128.46 KB	FB_WWW_DEV
ReactART-prod.js	-0.3%	-0.1%	236.48 KB	235.69 KB	39.83 KB	39.78 KB	FB_WWW_PROD
react-art.development.js	-0.1%	-0.0%	677.99 KB	677.5 KB	145.91 KB	145.87 KB	UMD_DEV
react-art.production.min.js	-0.1%	-0.1%	107.32 KB	107.23 KB	32.52 KB	32.48 KB	UMD_PROD
react-art.development.js	-0.1%	-0.0%	608.67 KB	608.18 KB	128.49 KB	128.46 KB	NODE_DEV
react-art.production.min.js	-0.1%	-0.1%	72.29 KB	72.2 KB	21.68 KB	21.66 KB	NODE_PROD

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom.profiling.min.js	-0.1%	-0.0%	123.72 KB	123.63 KB	38.78 KB	38.77 KB	NODE_PROFILING
react-dom-server.browser.development.js	0.0%	0.0%	137.99 KB	137.99 KB	36.67 KB	36.67 KB	UMD_DEV
react-dom-test-utils.development.js	0.0%	0.0%	54.76 KB	54.76 KB	15.39 KB	15.39 KB	UMD_DEV
react-dom-unstable-fizz.browser.production.min.js	0.0%	🔺+0.1%	1.21 KB	1.21 KB	710 B	711 B	UMD_PROD
react-dom-test-utils.development.js	0.0%	0.0%	53.03 KB	53.03 KB	15.06 KB	15.07 KB	NODE_DEV
react-dom-unstable-fizz.browser.development.js	0.0%	+0.1%	3.71 KB	3.71 KB	1.5 KB	1.5 KB	NODE_DEV
react-dom-test-utils.production.min.js	0.0%	0.0%	10.95 KB	10.95 KB	4.09 KB	4.09 KB	NODE_PROD
react-dom-unstable-fizz.browser.production.min.js	0.0%	🔺+0.2%	1.05 KB	1.05 KB	641 B	642 B	NODE_PROD
react-dom.development.js	-0.1%	-0.0%	957.32 KB	956.84 KB	215.12 KB	215.1 KB	UMD_DEV
react-dom.production.min.js	-0.1%	-0.1%	119.74 KB	119.64 KB	38.38 KB	38.34 KB	UMD_PROD
react-dom.profiling.min.js	-0.1%	-0.1%	123.47 KB	123.37 KB	39.56 KB	39.53 KB	UMD_PROFILING
react-dom.development.js	-0.1%	-0.0%	951.39 KB	950.9 KB	213.41 KB	213.39 KB	NODE_DEV
react-dom-server.node.development.js	0.0%	0.0%	135.03 KB	135.03 KB	35.88 KB	35.88 KB	NODE_DEV
react-dom.production.min.js	-0.1%	-0.0%	119.84 KB	119.75 KB	37.65 KB	37.63 KB	NODE_PROD
react-dom-server.browser.development.js	0.0%	0.0%	133.92 KB	133.92 KB	35.65 KB	35.65 KB	NODE_DEV
ReactDOM-dev.js	-0.1%	-0.0%	979 KB	978.2 KB	216.33 KB	216.25 KB	FB_WWW_DEV
ReactDOM-prod.js	-0.2%	-0.1%	393.92 KB	393 KB	71.97 KB	71.87 KB	FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js	0.0%	0.0%	60.91 KB	60.91 KB	16.07 KB	16.07 KB	UMD_DEV
ReactDOM-profiling.js	-0.2%	-0.1%	405.22 KB	404.26 KB	74.12 KB	74.03 KB	FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js	0.0%	0.0%	10.23 KB	10.23 KB	3.47 KB	3.47 KB	UMD_PROD
react-dom-unstable-native-dependencies.development.js	0.0%	0.0%	60.61 KB	60.61 KB	15.99 KB	16 KB	NODE_DEV
react-dom-unstable-fizz.node.development.js	0.0%	+0.1%	4.42 KB	4.42 KB	1.65 KB	1.65 KB	NODE_DEV
react-dom-unstable-native-dependencies.production.min.js	0.0%	0.0%	9.97 KB	9.97 KB	3.37 KB	3.37 KB	NODE_PROD
ReactDOMServer-dev.js	0.0%	0.0%	139.28 KB	139.28 KB	35.4 KB	35.41 KB	FB_WWW_DEV
react-dom-unstable-fizz.node.production.min.js	0.0%	🔺+0.1%	1.21 KB	1.21 KB	696 B	697 B	NODE_PROD

react-reconciler

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-reconciler-persistent.development.js	-0.1%	-0.0%	606.86 KB	606.38 KB	126.48 KB	126.45 KB	NODE_DEV
react-reconciler-reflection.development.js	0.0%	0.0%	19.53 KB	19.53 KB	6.4 KB	6.4 KB	NODE_DEV
react-reconciler-persistent.production.min.js	-0.1%	-0.1%	72.53 KB	72.45 KB	21.32 KB	21.29 KB	NODE_PROD
react-reconciler-reflection.production.min.js	0.0%	🔺+0.1%	2.86 KB	2.86 KB	1.24 KB	1.24 KB	NODE_PROD
react-reconciler.development.js	-0.1%	-0.0%	609.67 KB	609.18 KB	127.65 KB	127.63 KB	NODE_DEV
react-reconciler.production.min.js	-0.1%	-0.1%	75.29 KB	75.2 KB	21.96 KB	21.95 KB	NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against 3f72f8d

Remove unused arguments in the reconciler

3f72f8d

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 21, 2020

gaearon requested a review from acdlite February 21, 2020 01:40

acdlite approved these changes Feb 21, 2020

View reviewed changes

gaearon merged commit 8b596e0 into react:master Feb 21, 2020

gaearon deleted the rm-unused branch February 21, 2020 02:26

mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026

Remove unused arguments in the reconciler (react#18092)

c870937

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove unused arguments in the reconciler#18092

Remove unused arguments in the reconciler#18092
gaearon merged 1 commit into
react:masterfrom
gaearon:rm-unused

gaearon commented Feb 21, 2020

Uh oh!

sizebot commented Feb 21, 2020

react-native-renderer

react-reconciler

react-dom

react-art

react-test-renderer

Uh oh!

sizebot commented Feb 21, 2020

react-test-renderer

react-native-renderer

react-art

react-dom

react-reconciler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

gaearon commented Feb 21, 2020

Uh oh!

sizebot commented Feb 21, 2020

react-native-renderer

react-reconciler

react-dom

react-art

react-test-renderer

Size changes (stable)

Uh oh!

sizebot commented Feb 21, 2020

react-test-renderer

react-native-renderer

react-art

react-dom

react-reconciler

Size changes (experimental)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants