These flags are hard coded in our internal config#16883
Merged
Conversation
sebmarkbage
requested review from
acdlite,
bvaughn,
gaearon,
lunaruan,
necolas,
threepointone and
trueadm
September 25, 2019 04:30
By hard coding them here they can get properly DCE and don't have to be sent to users. The internal config should only have dynamic flags.
sebmarkbage
force-pushed
the
hardcodeflags
branch
from
September 25, 2019 04:35
4a6f793 to
afe1a5b
Compare
|
React: size: 0.0%, gzip: -0.0% ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: 32e5c97...afe1a5b react-dom
scheduler
react
react-art
|
acdlite
approved these changes
Sep 25, 2019
trueadm
approved these changes
Sep 25, 2019
gaearon
approved these changes
Sep 25, 2019
gaearon
reviewed
Sep 25, 2019
| export const warnAboutDeprecatedLifecycles = true; | ||
| export const warnAboutShorthandPropertyCollision = false; | ||
| export const warnAboutDeprecatedSetNativeProps = false; | ||
| export const disableLegacyContext = false; |
Collaborator
There was a problem hiding this comment.
We should make a GK for this one. I can do in a follow-up.
|
|
||
| export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false; | ||
| export const warnAboutDeprecatedLifecycles = true; | ||
| export const warnAboutShorthandPropertyCollision = false; |
threepointone
approved these changes
Sep 25, 2019
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
By hard coding them here they can get properly DCE and don't have to be sent to users. The internal config should only have dynamic flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By hard coding them here they can get properly DCE and don't have to be sent to users. The internal config should only have dynamic flags.