Remove experimental scheduler flags#16672
Merged
Merged
Conversation
acdlite
approved these changes
Sep 5, 2019
acdlite
reviewed
Sep 5, 2019
| // prevent idle periods. | ||
| let idleTimeoutID; | ||
| if (requestTimerEventBeforeFirstFrame) { | ||
| idleTimeoutID = setTimeout(function onTimerEventBeforeFirstFrame() { |
Collaborator
There was a problem hiding this comment.
Since you've removed this timeout, there's now no timeout fallback for the initial rAF call, like there is for subsequent rAFs: https://github.com/facebook/react/blob/ff006451ad792ed26793691402bf7b5f813205f7/packages/scheduler/src/forks/SchedulerHostConfig.default.js#L306-L311
But it's whatever since we're going to disable the rAF stuff anyway.
Collaborator
There was a problem hiding this comment.
That timeout should have already been in the else branch of this feature, anyway.
Collaborator
Author
There was a problem hiding this comment.
there's now no timeout fallback for the initial rAF call, like there is for subsequent rAFs
I guess that explains #16629?
|
React: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 040ca0f...51f728a react
scheduler
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
requestIdleCallbackBeforeFirstFrameandrequestTimerEventBeforeFirstFrame.Both were rAF-specific experiments but we went with MessageLoop instead. We left rAF temporarily in the code but since we never actually used these code paths, I think we should delete them to make the code easier to understand.