Strengthen nested update counter test coverage#15166
Merged
Merged
Conversation
This ensures their behavior is consistent when run in isolation, and that they actually test the cases they're describing.
These cases explicitly verify that we reset the counter in right places.
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
* Isolate ReactUpdates-test cases This ensures their behavior is consistent when run in isolation, and that they actually test the cases they're describing. * Add coverage for cases where we reset nestedUpdateCounter These cases explicitly verify that we reset the counter in right places. * Add a mutually recursive test case * Add test coverage for useLayoutEffect loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds isolation between tests because they used to interfere (e.g. with a change to the logic, a test could fail with other tests but pass when focused).
After adding isolation, I found a few situations that aren't really covered by existing cases alone, but that are important to test. So I'm adding explicit cases for those.