Add a low priority to the scheduler that still resolves#14155
Merged
Conversation
Details of bundled changes.Comparing: 051272f...da88002 scheduler
Generated by 🚫 dangerJS |
Contributor
|
Seems reasonable to me. Thoughts, @acdlite? |
sebmarkbage
approved these changes
Nov 8, 2018
Contributor
|
How about idle priority? :) |
Contributor
|
Oh duh, we already that one. I thought it was still "offscreen" or something. Let's merge and figure out the name later. |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
n8schloss
added a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normal priority is for things that we still want the user to see and idle pri is for things that are more speculative and may never resolve. We do not currently have a priority for things (like logging or sending data back to servers) where we want to ensure that it resolves, but where we want other things to be able to happen first. This adds such a priority.
I was debating a bit between calling it 'low' priority or 'logging' priority. I went with calling it 'low' because you can use this for way more than logging, but opening to changing it.