Skip to content

Remove duplicate import declarations causing RN_OSS build error#14062

Merged
gaearon merged 1 commit into
react:masterfrom
chrisbianca:patch-1
Nov 1, 2018
Merged

Remove duplicate import declarations causing RN_OSS build error#14062
gaearon merged 1 commit into
react:masterfrom
chrisbianca:patch-1

Conversation

@chrisbianca

Copy link
Copy Markdown
Contributor

Not much to write here.

The RN_OSS build currently fails due to 3 import declarations being duplicated.
This commit removes the duplicates and ensures that the build works correctly.

@sizebot

sizebot commented Nov 1, 2018

Copy link
Copy Markdown
Fails
🚫

node` failed.

Log

Error:  { FetchError: invalid json response body at http://react.zpao.com/builds/master/_commits/d5d10d140ed8739c83f3cee5d43f0bf60eea1002/results.json reason: Unexpected token < in JSON at position 0
    at /home/circleci/project/node_modules/node-fetch/lib/body.js:48:31
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)
  name: 'FetchError',
  message: 'invalid json response body at http://react.zpao.com/builds/master/_commits/d5d10d140ed8739c83f3cee5d43f0bf60eea1002/results.json reason: Unexpected token < in JSON at position 0',
  type: 'invalid-json' }

Generated by 🚫 dangerJS

@gaearon
gaearon merged commit 595b4f9 into react:master Nov 1, 2018
@gaearon

gaearon commented Nov 1, 2018

Copy link
Copy Markdown
Collaborator

Thanks

jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants