[Native] If statement cleanup for null targets (#17346)

elicwhite · elicwhite · commit bb1853f73313 · 2019-11-20T14:50:36.000-08:00
diff --git a/packages/react-native-renderer/src/ReactFabricEventEmitter.js b/packages/react-native-renderer/src/ReactFabricEventEmitter.js
@@ -43,11 +43,9 @@ export function dispatchEvent(
     );
   }
 
-  let eventTarget;
+  let eventTarget = null;
   if (enableNativeTargetAsInstance) {
-    if (targetFiber == null) {
-      eventTarget = null;
-    } else {
+    if (targetFiber != null) {
       eventTarget = targetFiber.stateNode.canonical;
     }
   } else {
diff --git a/packages/react-native-renderer/src/ReactNativeEventEmitter.js b/packages/react-native-renderer/src/ReactNativeEventEmitter.js
@@ -100,11 +100,9 @@ function _receiveRootNodeIDEvent(
   const nativeEvent = nativeEventParam || EMPTY_NATIVE_EVENT;
   const inst = getInstanceFromNode(rootNodeID);
 
-  let target;
+  let target = null;
   if (enableNativeTargetAsInstance) {
-    if (inst == null) {
-      target = null;
-    } else {
+    if (inst != null) {
       target = inst.stateNode;
     }
   } else {

Original file line number	Diff line number	Diff line change
`@@ -43,11 +43,9 @@ export function dispatchEvent(`
`43`	`43`	`);`
`44`	`44`	`}`
`45`	`45`
`46`		`- let eventTarget;`
	`46`	`+ let eventTarget = null;`
`47`	`47`	`if (enableNativeTargetAsInstance) {`
`48`		`- if (targetFiber == null) {`
`49`		`- eventTarget = null;`
`50`		`- } else {`
	`48`	`+ if (targetFiber != null) {`
`51`	`49`	`eventTarget = targetFiber.stateNode.canonical;`
`52`	`50`	`}`
`53`	`51`	`} else {`