[Fiber] Fix missing render times when we cancel a pending commit (#31065)

eps1lon · web-flow · commit 778e1ed2e5ec · 2024-09-26T00:20:03.000+02:00
diff --git a/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js b/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js
@@ -3401,7 +3401,7 @@ export function suspendResource(
   }
 }
 
-export function waitForCommitToBeReady(): null | (Function => Function) {
+export function waitForCommitToBeReady(): null | ((() => void) => () => void) {
   if (suspendedState === null) {
     throw new Error(
       'Internal React Error: suspendedState null when it was expected to exists. Please report this as a React bug.',
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.js b/packages/react-reconciler/src/ReactFiberWorkLoop.js
@@ -1308,6 +1308,8 @@ function commitRootWhenReady(
           updatedLanes,
           suspendedRetryLanes,
           SUSPENDED_COMMIT,
+          completedRenderStartTime,
+          completedRenderEndTime,
         ),
       );
       const didAttemptEntireTree = !didSkipSuspendedSiblings;
@@ -3001,8 +3003,6 @@ function commitRoot(
     ReactSharedInternals.T = prevTransition;
     setCurrentUpdatePriority(previousUpdateLanePriority);
   }
-
-  return null;
 }
 
 function commitRootImpl(

Original file line number	Diff line number	Diff line change
`@@ -3401,7 +3401,7 @@ export function suspendResource(`
`3401`	`3401`	`}`
`3402`	`3402`	`}`
`3403`	`3403`
`3404`		`-export function waitForCommitToBeReady(): null \| (Function => Function) {`
	`3404`	`+export function waitForCommitToBeReady(): null \| ((() => void) => () => void) {`
`3405`	`3405`	`if (suspendedState === null) {`
`3406`	`3406`	`throw new Error(`
`3407`	`3407`	`'Internal React Error: suspendedState null when it was expected to exists. Please report this as a React bug.',`