Fix noFallthroughCasesInSwitch/jsx object is not extensible by ryota-murakami · Pull Request #9921 · react/create-react-app

ryota-murakami · 2020-10-27T07:21:29Z

Relative Issues #9868 #9429

I fixed broken yarn start that cause react-scripts can't handle correctly noFallthroughCasesInSwitch and jsx compileOptions.

Thank you for your decent review 😀

…or at TypeScript

mrmckeb

@iansu @ianschmitz I've had this reported to me privately too, this seems like a change to the behaviour of ts.readConfigFile where the object is no longer extensible.

mrmckeb · 2020-10-27T08:24:03Z

Re-running CI.

benneq · 2020-10-27T11:57:53Z

@ryota-murakami Have you check the inner properties of compilerOptions? Those should be frozen, too. Though a simple appTsConfig.compilerOptions = { ...appTsConfig.compilerOptions }; might not work.

ryota-murakami · 2020-10-30T13:02:33Z

@benneq @KonstantinSimeonov I'm sorry for slow response.

Have you check the inner properties of compilerOptions? Those should be frozen, too. Though a simple appTsConfig.compilerOptions = { ...appTsConfig.compilerOptions }; might not work.

I've checked inner properties of compilerOptions are frozen.
Bellow screenshot showing Object.isFrozen(appTsConfig.compilerOptions.module) return true after destructured property of appTsConfig.compilerOptions on new Object.

And I'll share video clip that recorded running bellow code without Error.

  if (appTsConfig.compilerOptions == null) {
    appTsConfig.compilerOptions = {};
    firstTimeSetup = true;
  } else {
    appTsConfig.compilerOptions = { ...appTsConfig.compilerOptions };
    for(const option in appTsConfig.compilerOptions) {
      if (!Object.isFrozen(option)) new Error('appTsConfig.compilerOptions option should be frozen')
    }
  }

https://www.dropbox.com/s/912pp3xudr9rn9s/Screen%20Recording%202020-10-30%20at%2021.40.54.mov?dl=0

KonstantinSimeonov · 2020-10-30T16:12:24Z

@ryota-murakami

    for(const option in appTsConfig.compilerOptions) {
      if (!Object.isFrozen(option)) new Error('appTsConfig.compilerOptions option should be frozen')
    }

This is iterating over the keys of the object, which are strings and are always frozen and is not checking whether the properties are frozen or not 😛 . I think @benneq 's idea was to make sure that no crashes would occur if any of appTsConfig.compilerOptions's properties is frozen. Although I think that this is unlikely, you can safeguard against it by deep cloning the whole object.

Co-authored-by: Konstantin Simeonov <[email protected]>

ryota-murakami · 2020-10-30T18:45:43Z

@KonstantinSimeonov Thanks, that iterator is garbage 😅
And merge your suggested solution. I confirm that working.

But I don't understand why guys care about property frozen status?
This problem root is Object isn't extensible, co script couldn't add suggested config.
I think it doesn't matter frozen status 🤔

ianschmitz · 2020-10-30T23:05:06Z

Thanks folks!

ryota-murakami · 2020-11-01T07:12:41Z

@benneq @KonstantinSimeonov I got it why should we handle isFroze() result of each compileOptions.
If isFroze(someOption) === true and original config from reading files value is different from CRA suggested,
the script couldn't apply change to suggested value.

Thank you for your support about this PR!

vegawong · 2020-11-10T10:37:04Z

@ianschmitz should it make a new release version?

due to 9921 is not released yet (react/create-react-app#9921)

cseas · 2020-11-22T16:31:23Z

Can we please have a release with this fix? The problem is occurring for a lot of people in #9868

* Fix noFallthroughCasesInSwitch/jsx object is not extensible (react#9921) Co-authored-by: Konstantin Simeonov <[email protected]> * Add logo license to README * Remove trailing space in reportWebVitals.ts (react#10040) * docs: add React Testing Library as a library requiring jsdom (react#10052) Co-authored-by: Ian Schmitz <[email protected]> * Increase Workbox's maximumFileSizeToCacheInBytes (react#10048) * Create FUNDING.yml * replace inquirer with prompts (react#10083) - remove `react-dev-utils/inquirer` public import * Prepare 4.0.1 release * Prepare 4.0.1 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Co-authored-by: Ryota Murakami <[email protected]> Co-authored-by: Konstantin Simeonov <[email protected]> Co-authored-by: Ian Sutherland <[email protected]> Co-authored-by: sho90 <[email protected]> Co-authored-by: Anyul Rivas <[email protected]> Co-authored-by: Ian Schmitz <[email protected]> Co-authored-by: Jeffrey Posnick <[email protected]> Co-authored-by: Evan Bacon <[email protected]>

* Fix noFallthroughCasesInSwitch/jsx object is not extensible (react#9921) Co-authored-by: Konstantin Simeonov <[email protected]> * Add logo license to README * Remove trailing space in reportWebVitals.ts (react#10040) * docs: add React Testing Library as a library requiring jsdom (react#10052) Co-authored-by: Ian Schmitz <[email protected]> * Increase Workbox's maximumFileSizeToCacheInBytes (react#10048) * Create FUNDING.yml * replace inquirer with prompts (react#10083) - remove `react-dev-utils/inquirer` public import * Prepare 4.0.1 release * Prepare 4.0.1 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * chore: bump web-vital dependency version (react#10143) * chore: bump typescript version (react#10141) Co-authored-by: Ian Schmitz <[email protected]> * Add TypeScript 4.x as peerDependency to react-scripts(react#9964) * remove chalk from formatWebpackMessages (react#10198) * Upgrade @svgr/webpack to fix build error (react#10213) Co-authored-by: Ian Schmitz <[email protected]> * Improve vendor chunk names in development (react#9569) * Update postcss packages (react#10003) Co-authored-by: Ian Schmitz <[email protected]> * Recovered some integration tests (react#10091) * Upgrade sass-loader (react#9988) * Move ESLint cache file into node_modules (react#9977) Co-authored-by: Ian Schmitz <[email protected]> * Revert "Update postcss packages" (react#10216) This reverts commit 580ed5d. * Remove references to Node 8 (react#10214) * fix(react-scripts): add missing peer dependency react and update react-refresh-webpack-plugin (react#9872) * Update using-the-public-folder.md (react#10314) Some library --> Some libraries * docs: add missing override options for Jest config (react#9473) * Fix CI tests (react#10217) * appTsConfig immutability handling by immer (react#10027) Co-authored-by: mad-jose <[email protected]> * Add support for new BUILD_PATH advanced configuration variable (react#8986) * Add opt-out for eslint-webpack-plugin (react#10170) * Prepare 4.0.2 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * tests: update test case to match the description (react#10384) * Bump webpack-dev-server 3.11.0 -> 3.11.1 (react#10312) Resolves react#10084 security vulnerability in websocket-driver library version 0.5.6, imported transitively by sockjs * Upgrade eslint-webpack-plugin to fix opt-out flag (react#10590) * update immer to 8.0.1 to address vulnerability (react#10412) Resolves react#10411 Bumps immer version to 8.0.1 to address the prototype pollution vulnerability with the current 7.0.9 version. * Prepare 4.0.3 release * Update CHANGELOG * Publish - [email protected] - [email protected] - [email protected] Co-authored-by: Ryota Murakami <[email protected]> Co-authored-by: Konstantin Simeonov <[email protected]> Co-authored-by: Ian Sutherland <[email protected]> Co-authored-by: sho90 <[email protected]> Co-authored-by: Anyul Rivas <[email protected]> Co-authored-by: Ian Schmitz <[email protected]> Co-authored-by: Jeffrey Posnick <[email protected]> Co-authored-by: Evan Bacon <[email protected]> Co-authored-by: Sahil Purav <[email protected]> Co-authored-by: Hakjoon Sim <[email protected]> Co-authored-by: Chris Shepherd <[email protected]> Co-authored-by: Jason Williams <[email protected]> Co-authored-by: Jabran Rafique⚡️ <[email protected]> Co-authored-by: John Ruble <[email protected]> Co-authored-by: Morten N.O. Nørgaard Henriksen <[email protected]> Co-authored-by: Sergey Makarov <[email protected]> Co-authored-by: EhsanKhaki <[email protected]> Co-authored-by: Kristoffer K <[email protected]> Co-authored-by: Aviv Hadar <[email protected]> Co-authored-by: Tobias Büschel <[email protected]> Co-authored-by: mad-jose <[email protected]> Co-authored-by: mad-jose <[email protected]> Co-authored-by: Andrew Hyndman <[email protected]> Co-authored-by: Brody McKee <[email protected]> Co-authored-by: James George <[email protected]> Co-authored-by: Dion Woolley <[email protected]> Co-authored-by: Walker Clem <[email protected]>

Co-authored-by: Konstantin Simeonov <[email protected]>

4.0.0 Fix noFallthroughCasesInSwitch/jsx object is not extensible err…

99f9a22

…or at TypeScript

ryota-murakami requested review from ianschmitz, iansu, mrmckeb and petetnt as code owners October 27, 2020 07:21

facebook-github-bot added the CLA Signed label Oct 27, 2020

n3tr mentioned this pull request Oct 27, 2020

fix: correct JsxEmit value typo from ReactJsx to ReactJSX #9920

Closed

mrmckeb approved these changes Oct 27, 2020

View reviewed changes

mrmckeb closed this Oct 27, 2020

mrmckeb reopened this Oct 27, 2020

ianschmitz added this to the 4.0.1 milestone Oct 28, 2020

KonstantinSimeonov reviewed Oct 29, 2020

View reviewed changes

Comment thread packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js Outdated

Update packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js

8d53a29

Co-authored-by: Konstantin Simeonov <[email protected]>

ianschmitz added the tag: bug fix label Oct 30, 2020

ianschmitz changed the title ~~4.0.0 Fix noFallthroughCasesInSwitch/jsx object is not extensible err…~~ Fix noFallthroughCasesInSwitch/jsx object is not extensible Oct 30, 2020

ianschmitz merged commit 3a98ed1 into react:master Oct 30, 2020

This was referenced Oct 30, 2020

4.0 alpha - TypeError: Cannot add property noFallthroughCasesInSwitch, object is not extensible #9429

Closed

4.0.0 breaks with typescript (all versions) #9868

Closed

ryota-murakami deleted the fix-4.0.0-typescript-broken branch October 31, 2020 09:14

y-yagi mentioned this pull request Nov 15, 2020

Bump react-scripts from 3.4.3 to 4.0.0 y-yagi/note-page-old#407

Closed

oklas mentioned this pull request Nov 20, 2020

CRA 4.0 support? oklas/react-app-alias#9

Closed

benneq mentioned this pull request Nov 20, 2020

Fix react-jsx error #9869

Merged

oklas added a commit to oklas/react-app-alias that referenced this pull request Nov 21, 2020

fix(example): patch create-react-app 4.0

600ffb4

due to 9921 is not released yet (react/create-react-app#9921)

wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021

Fix noFallthroughCasesInSwitch/jsx object is not extensible (react#9921)

22164e1

Co-authored-by: Konstantin Simeonov <[email protected]>

ryota-murakami mentioned this pull request Jul 7, 2021

We need regualr CRA maintainer #11180

Closed

abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023

Fix noFallthroughCasesInSwitch/jsx object is not extensible (react#9921)

5c21b7a

Co-authored-by: Konstantin Simeonov <[email protected]>

abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023

Fix noFallthroughCasesInSwitch/jsx object is not extensible (react#9921)

2cead4f

Co-authored-by: Konstantin Simeonov <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix noFallthroughCasesInSwitch/jsx object is not extensible#9921

Fix noFallthroughCasesInSwitch/jsx object is not extensible#9921
ianschmitz merged 2 commits into
react:masterfrom
ryota-murakami:fix-4.0.0-typescript-broken

ryota-murakami commented Oct 27, 2020

Uh oh!

mrmckeb left a comment

Uh oh!

mrmckeb commented Oct 27, 2020

Uh oh!

benneq commented Oct 27, 2020

Uh oh!

Uh oh!

ryota-murakami commented Oct 30, 2020

Uh oh!

KonstantinSimeonov commented Oct 30, 2020 •

edited

Loading

Uh oh!

ryota-murakami commented Oct 30, 2020

Uh oh!

ianschmitz commented Oct 30, 2020

Uh oh!

ryota-murakami commented Nov 1, 2020 •

edited

Loading

Uh oh!

vegawong commented Nov 10, 2020

Uh oh!

cseas commented Nov 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

ryota-murakami commented Oct 27, 2020

Uh oh!

mrmckeb left a comment

Choose a reason for hiding this comment

Uh oh!

mrmckeb commented Oct 27, 2020

Uh oh!

benneq commented Oct 27, 2020

Uh oh!

Uh oh!

ryota-murakami commented Oct 30, 2020

Uh oh!

KonstantinSimeonov commented Oct 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryota-murakami commented Oct 30, 2020

Uh oh!

ianschmitz commented Oct 30, 2020

Uh oh!

ryota-murakami commented Nov 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vegawong commented Nov 10, 2020

Uh oh!

cseas commented Nov 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

KonstantinSimeonov commented Oct 30, 2020 •

edited

Loading

ryota-murakami commented Nov 1, 2020 •

edited

Loading