Remove outdated docs regarding vscode eslint extension and typescript autofix#8307
Conversation
|
Hi alex-vukovity-cko! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
john-james-gh
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks! |
4 participants
I would like to remove documentation that is no longer relevant (outdated). It is regarding ESLint extension for Visual Studio Code and its Typescript support. microsoft/vscode-eslint#609
Before ESLint extension version 2.0.4 (before December 16, 2019 source:
https://github.com/microsoft/vscode-eslint/releases), the extension did not have Typescript support (auto-fix feature) enabled by default and it had to be enabled manually by adding a specific configuration in
.vscode/settings.json(the block removed by this PR)As aforesaid, this issue with ESLint not having TypeScript support enabled by default has been fixed with version 2.0.4 (released on Dec 16, 2019) and this block of code (workaround) is no longer relevant.
source: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint
In fact this configuration is now squiggle-lined once added to
.vscode/settings.jsonwith a warning as shown in the screenshot.