Typescript init: suggest jsx: "react" in tsconfig #7472
Conversation
itsMapleLeaf
requested review from
bugzpodder,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks @kingdaro. This is a good improvement. |
3 participants
Transpilation is done by Babel, which ignores the tsconfig, so this setting (or any tsconfig setting) doesn't affect compilation, only type checking.
Setting it to
reactraises a type error if react is not imported, and gives a quick fix to import react. The linter rule does not give a quick fix.I've set it to suggest the value
reactinstead of forcing it, because people might need to set it to something else in their project for whatever reason.Verified that it works by cloning create-react-app from master, installing the local versions, and using it to compile a personal project. Setting
"jsx": "react"does not affect the build size or content.