don't overwrite __name__ with __qualname__

rdpate · rdpate · commit 498709561f57 · 2016-09-24T18:35:25.000-04:00
diff --git a/src/attr/_make.py b/src/attr/_make.py
@@ -285,12 +285,7 @@ def wrap(cls):
                 cls_dict.pop(ca_name, None)
             cls_dict.pop('__dict__', None)
 
-            if repr_ns is None:
-                cls_name = getattr(cls, "__qualname__", cls.__name__)
-            else:
-                cls_name = cls.__name__
-
-            cls = type(cls_name, cls.__bases__, cls_dict)
+            cls = type(cls.__name__, cls.__bases__, cls_dict)
 
         return cls
 
diff --git a/tests/test_make.py b/tests/test_make.py
@@ -287,6 +287,21 @@ class D(object):
                 pass
         assert "C.D()" == repr(C.D())
 
+    @pytest.mark.skipif(PY2, reason="__qualname__ is PY3-only.")
+    @given(slots_outer=booleans(), slots_inner=booleans())
+    def test_name_not_overridden(self, slots_outer, slots_inner):
+        """
+        On Python 3, __name__ should not be the same as __qualname__ for nested classes.
+        """
+        @attributes(slots=slots_outer)
+        class C(object):
+            @attributes(slots=slots_inner)
+            class D(object):
+                pass
+
+        assert C.D.__name__ == "D"
+        assert C.D.__qualname__ == "C.D"
+
 
 @attributes
 class GC(object):
