Skip to content
This repository was archived by the owner on Mar 7, 2024. It is now read-only.

Fixes for windows & enable in CI#98

Closed
kipz wants to merge 1 commit intordimitrov:mainfrom
kipz:main
Closed

Fixes for windows & enable in CI#98
kipz wants to merge 1 commit intordimitrov:mainfrom
kipz:main

Conversation

@kipz
Copy link
Copy Markdown

@kipz kipz commented Jan 25, 2024

Since windows tests were disabled, it looks like we've drifted a bit and introduced a few issues preventing the tests from passing and from the project working on windows:

  • use of unix path separators throughout
  • tests relying on line endings, and Git checkouts being different for windows/linux
  • renaming of files between drives on windows on GitHub Actions
  • renaming of open files (not allowed on windows)

Signed-off-by: James Carnegie <[email protected]>
@rdimitrov
Copy link
Copy Markdown
Owner

@kipz - Thank you for you PR! 🙏

We've been focusing on building up a volume of tests that we really missed ensuring they work properly for windows.

@rdimitrov
Copy link
Copy Markdown
Owner

Hey, @kipz,

Do you mind opening the same PR against https://github.com/theupdateframework/go-tuf/tree/master?

Since we've just moved the code to go-tuf, I'm probably going to archive this repository in the next few weeks so people know it's being deprecated in favour of https://github.com/theupdateframework/go-tuf/tree/master?

@kipz
Copy link
Copy Markdown
Author

kipz commented Jan 29, 2024

As requested: theupdateframework/go-tuf#586

@kipz kipz closed this Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants