s3: Added --s3-disable-http2 to disable http/2
#4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthShadow
commented
Oct 12, 2020
darthShadow
commented
Oct 12, 2020
| @@ -1381,6 +1393,19 @@ func (o *Object) split() (bucket, bucketPath string) { | |||
| return o.fs.split(o.remote) | |||
| } | |||
|
|
|||
| // getClient makes an http client according to the options | |||
| func getClient(opt *Options) *http.Client { | |||
| // TODO: Do we need cookies too? | |||
There was a problem hiding this comment.
@ncw Do we need the cookies too btw? I noticed that even for Google drive the cookie jar is not set so am not sure whether we need that or not?
ncw
reviewed
Oct 12, 2020
| func getClient(opt *Options) *http.Client { | ||
| // TODO: Do we need cookies too? | ||
| t := fshttp.NewTransportCustom(fs.Config, func(t *http.Transport) { | ||
| if opt.DisableHTTP2 { |
There was a problem hiding this comment.
Aside: It occurs to me that this would be easy to make a global option... That doesn't disable it per backend but it might be useful for debugging.
There was a problem hiding this comment.
Yep, had the same thought. I also wanted to add experimental support for quic (using quic-go) in the fshttp client so will probably do both of them together when I get around to it.
Signed-off-by: Anagh Kumar Baranwal <[email protected]>
darthShadow
force-pushed
the
fix-s3-http2
branch
from
404e1fe to
4daf29d
Compare
ncw
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Added flag to disable HTTP/2 on S3 backends. Fixes #4673
Was the change discussed in an issue or in the forum before?
#4673
Checklist