Remove old distro's dependent code that has already reached EOL #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI is failing on Foxy, but that is to be expected since the necessary code has been removed. |
pojiro
approved these changes
Mar 3, 2025
Member
pojiro
left a comment
pojiro
left a comment
There was a problem hiding this comment.
I also checked the codes. LGTM. This PR makes codes simple. I like this way too.
Member
Author
|
@pojiro thank you for your comment! go merging!! |
takasehideki
added a commit
that referenced
this pull request
Mar 4, 2025
\## v0.12.0 on 04 Mar 2025 **Full Changelog**: v0.11.3...v0.12.0 * New features: * Support jazzy by @pojiro in #361 * Remove old distro's dependent code that has already reached EOL by @takasehideki in #365 * Bump supported versions and CI targets by @takasehideki in #364 * Reapply git_hooks (v0.8.0 that has been addressed about path issue) by @takasehideki in #366 * Code Improvements/Fixes: * Patch for #366 by @pojiro in #368 * Bumps: none * Note in this release: * Please welecome Jazzy Jalisco to our supported ROS 2 LTS distribution!! 🎉 * We decided to stop the support for old distributions (Foxy, Galactic and Iron) which have already reached EOL because of the concentrataion of our development resources in the future. If you want to use these distributions, please consider to employ v0.11.3 or earlier (see [#PR365](#365)).
Merged
FelixPe
pushed a commit
to FelixPe/rclex
that referenced
this pull request
Mar 14, 2025
\## v0.12.0 on 04 Mar 2025 **Full Changelog**: rclex/rclex@v0.11.3...v0.12.0 * New features: * Support jazzy by @pojiro in rclex#361 * Remove old distro's dependent code that has already reached EOL by @takasehideki in rclex#365 * Bump supported versions and CI targets by @takasehideki in rclex#364 * Reapply git_hooks (v0.8.0 that has been addressed about path issue) by @takasehideki in rclex#366 * Code Improvements/Fixes: * Patch for rclex#366 by @pojiro in rclex#368 * Bumps: none * Note in this release: * Please welecome Jazzy Jalisco to our supported ROS 2 LTS distribution!! 🎉 * We decided to stop the support for old distributions (Foxy, Galactic and Iron) which have already reached EOL because of the concentrataion of our development resources in the future. If you want to use these distributions, please consider to employ v0.11.3 or earlier (see [#PR365](rclex#365)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed code depending on Foxy, Galactic, and Iron, which have already reached EOL. Although it may be good idea to keep these codes because they were appropriately macro-switching, I want to suggest that removing them could improve maintainability and concentrate our development resources in the future.
For those who insist on using the older distributions, I have noted that they should be usable for v0.11.3 or earlier.
This PR will fix #333
@pojiro please share your thoughts!!
Just FYI, I have removed these codes found by grep, but are there any others left?