Support jazzy #361
Merged
Support jazzy #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pojiro
commented
Feb 16, 2025
Comment on lines
+33
to
+37
| #ifdef ROS_DISTRO_jazzy | ||
| rc = rcl_timer_init2(&timer, clock_p, context_p, RCL_MS_TO_NS(period_ms), NULL, allocator, true); | ||
| #else | ||
| rc = rcl_timer_init(&timer, clock_p, context_p, RCL_MS_TO_NS(period_ms), NULL, allocator); | ||
| #endif |
Member
Author
There was a problem hiding this comment.
rcl_timer_init has been deprecated in Jazzy.
| ROS_INCS ?= rcl rcutils rmw rcl_yaml_param_parser type_description_interfaces rosidl_runtime_c service_msgs builtin_interfaces rosidl_typesupport_interface rosidl_dynamic_typesupport | ||
| ROS_CFLAGS ?= $(addprefix -I$(ROS_DIR)/include/, $(ROS_INCS)) | ||
| else ifeq ($(ROS_DISTRO), jazzy) | ||
| ROS_INCS ?= rcl rcutils rmw rcl_yaml_param_parser type_description_interfaces rosidl_runtime_c service_msgs builtin_interfaces rosidl_typesupport_interface rosidl_dynamic_typesupport |
Member
Author
There was a problem hiding this comment.
I checked that all include headers are same as iron.
| matrix: | ||
| dockertags: [ | ||
| latest, | ||
| jazzy-ex1.17.3-otp27.2, |
Member
Author
There was a problem hiding this comment.
Thanks for making this image.
Member
|
@pojiro thank you so much!!
I am particularly concerned about the last point, as I remember that with Iron it worked fine in the native environment, but there were issues compiling for Nerves. Please let me know if you have already checked this point. |
takasehideki
added a commit
that referenced
this pull request
Feb 25, 2025
**Full Changelog**: v0.11.2...v0.11.3 * New features: none * Code Improvements/Fixes: none * Bumps: * Bump nimble_parsec from 1.4.0 to 1.4.2 by @dependabot in #360 * Bump credo from 1.7.8 to 1.7.11 by @dependabot in #358 * Bump ex_doc from 0.34.2 to 0.36.1 by @dependabot in #357 * Bump elixir_make from 0.8.4 to 0.9.0 by @dependabot in #353 * Bump dialyxir from 1.4.4 to 1.4.5 by @dependabot in #354 * Manually update of deps by `mix deps.update --all` by @takasehideki in #362 * Note in this release: * This may be the final release to support old ROS distribution, e.g., Foxy, Galactic and Iron. * Support for Jazzy is available in `main` branch. We'd like to release this ASAP (ref: #361)
Merged
takasehideki
approved these changes
Feb 25, 2025
Member
takasehideki
left a comment
takasehideki
left a comment
There was a problem hiding this comment.
I did "Re-run all jobs" for CI test after merging v0.11.3, of course it passed with no problems. So I will merge this!
takasehideki
added a commit
that referenced
this pull request
Mar 4, 2025
\## v0.12.0 on 04 Mar 2025 **Full Changelog**: v0.11.3...v0.12.0 * New features: * Support jazzy by @pojiro in #361 * Remove old distro's dependent code that has already reached EOL by @takasehideki in #365 * Bump supported versions and CI targets by @takasehideki in #364 * Reapply git_hooks (v0.8.0 that has been addressed about path issue) by @takasehideki in #366 * Code Improvements/Fixes: * Patch for #366 by @pojiro in #368 * Bumps: none * Note in this release: * Please welecome Jazzy Jalisco to our supported ROS 2 LTS distribution!! 🎉 * We decided to stop the support for old distributions (Foxy, Galactic and Iron) which have already reached EOL because of the concentrataion of our development resources in the future. If you want to use these distributions, please consider to employ v0.11.3 or earlier (see [#PR365](#365)).
Merged
FelixPe
pushed a commit
to FelixPe/rclex
that referenced
this pull request
Mar 14, 2025
\## v0.12.0 on 04 Mar 2025 **Full Changelog**: rclex/rclex@v0.11.3...v0.12.0 * New features: * Support jazzy by @pojiro in rclex#361 * Remove old distro's dependent code that has already reached EOL by @takasehideki in rclex#365 * Bump supported versions and CI targets by @takasehideki in rclex#364 * Reapply git_hooks (v0.8.0 that has been addressed about path issue) by @takasehideki in rclex#366 * Code Improvements/Fixes: * Patch for rclex#366 by @pojiro in rclex#368 * Bumps: none * Note in this release: * Please welecome Jazzy Jalisco to our supported ROS 2 LTS distribution!! 🎉 * We decided to stop the support for old distributions (Foxy, Galactic and Iron) which have already reached EOL because of the concentrataion of our development resources in the future. If you want to use these distributions, please consider to employ v0.11.3 or earlier (see [#PR365](rclex#365)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@takasehideki This is the PR for supporting
jazzy.