Pyrefly

rchen152 · rchen152 · commit 5233b91801bc · 2025-12-05T13:49:39.000-08:00
diff --git a/.github/workflows/typing-checks.yml b/.github/workflows/typing-checks.yml
@@ -64,6 +64,10 @@ jobs:
           uv pip install -r requirements-dev.txt
           uv pip install .
           uv pip install mypy
+          uv pip install pyrefly==0.44.2
 
       - name: Run MyPy type checking
         run: mypy
+
+      - name: Run Pyrefly type checking
+        run: pyrefly check
diff --git a/ignite/contrib/engines/common.py b/ignite/contrib/engines/common.py
@@ -265,6 +265,7 @@ def _setup_common_distrib_training_handlers(
 
         @trainer.on(Events.EPOCH_STARTED)
         def distrib_set_epoch(engine: Engine) -> None:
+            # pyrefly: ignore [missing-attribute]
             train_sampler.set_epoch(engine.state.epoch - 1)
 
 
diff --git a/ignite/contrib/engines/tbptt.py b/ignite/contrib/engines/tbptt.py
@@ -117,5 +117,6 @@ def _update(engine: Engine, batch: Sequence[torch.Tensor]) -> float:
         return sum(loss_list) / len(loss_list)
 
     engine = Engine(_update)
+    # pyrefly: ignore [bad-argument-type]
     engine.register_events(*Tbptt_Events)
     return engine
diff --git a/ignite/contrib/handlers/base_logger.py b/ignite/contrib/handlers/base_logger.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/base_logger.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/clearml_logger.py b/ignite/contrib/handlers/clearml_logger.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/clearml_logger.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/lr_finder.py b/ignite/contrib/handlers/lr_finder.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/lr_finder.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/mlflow_logger.py b/ignite/contrib/handlers/mlflow_logger.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/mlflow_logger.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/neptune_logger.py b/ignite/contrib/handlers/neptune_logger.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/neptune_logger.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/param_scheduler.py b/ignite/contrib/handlers/param_scheduler.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/param_scheduler.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/polyaxon_logger.py b/ignite/contrib/handlers/polyaxon_logger.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/polyaxon_logger.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/tensorboard_logger.py b/ignite/contrib/handlers/tensorboard_logger.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/tensorboard_logger.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/time_profilers.py b/ignite/contrib/handlers/time_profilers.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/time_profilers.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/tqdm_logger.py b/ignite/contrib/handlers/tqdm_logger.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/tqdm_logger.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/visdom_logger.py b/ignite/contrib/handlers/visdom_logger.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/visdom_logger.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/handlers/wandb_logger.py b/ignite/contrib/handlers/wandb_logger.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/handlers/wandb_logger.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/metrics/average_precision.py b/ignite/contrib/metrics/average_precision.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to /ignite/metrics/average_precision.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/metrics/cohen_kappa.py b/ignite/contrib/metrics/cohen_kappa.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to ignite/metrics/cohen_kappa.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/metrics/gpu_info.py b/ignite/contrib/metrics/gpu_info.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to ignite/metrics/gpu_info.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/metrics/precision_recall_curve.py b/ignite/contrib/metrics/precision_recall_curve.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to ignite/metrics/precision_recall_curve.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/contrib/metrics/regression/canberra_metric.py b/ignite/contrib/metrics/regression/canberra_metric.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/canberra_metric.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/fractional_absolute_error.py b/ignite/contrib/metrics/regression/fractional_absolute_error.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/fractional_absolute_error.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/fractional_bias.py b/ignite/contrib/metrics/regression/fractional_bias.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/fractional_bias.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/geometric_mean_absolute_error.py b/ignite/contrib/metrics/regression/geometric_mean_absolute_error.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/geometric_mean_absolute_error.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/geometric_mean_relative_absolute_error.py b/ignite/contrib/metrics/regression/geometric_mean_relative_absolute_error.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/geometric_mean_relative_absolute_error.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/manhattan_distance.py b/ignite/contrib/metrics/regression/manhattan_distance.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/manhattan_distance.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/maximum_absolute_error.py b/ignite/contrib/metrics/regression/maximum_absolute_error.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/maximum_absolute_error.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/mean_absolute_relative_error.py b/ignite/contrib/metrics/regression/mean_absolute_relative_error.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/mean_absolute_relative_error.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/mean_error.py b/ignite/contrib/metrics/regression/mean_error.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/mean_error.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/mean_normalized_bias.py b/ignite/contrib/metrics/regression/mean_normalized_bias.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/mean_normalized_bias.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/median_absolute_error.py b/ignite/contrib/metrics/regression/median_absolute_error.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/median_absolute_error.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/median_absolute_percentage_error.py b/ignite/contrib/metrics/regression/median_absolute_percentage_error.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/median_absolute_percentage_error.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/median_relative_absolute_error.py b/ignite/contrib/metrics/regression/median_relative_absolute_error.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/median_relative_absolute_error.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/r2_score.py b/ignite/contrib/metrics/regression/r2_score.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/r2_score.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/regression/wave_hedges_distance.py b/ignite/contrib/metrics/regression/wave_hedges_distance.py
@@ -8,6 +8,7 @@
 
 removed_in = "0.6.0"
 deprecation_warning = (
+    # pyrefly: ignore [redundant-condition]
     f"{__file__} has been moved to ignite/metrics/regression/wave_hedges_distance.py"
     f" and will be removed in version {removed_in}"
     if removed_in
diff --git a/ignite/contrib/metrics/roc_auc.py b/ignite/contrib/metrics/roc_auc.py
@@ -9,6 +9,7 @@
 removed_in = "0.6.0"
 deprecation_warning = (
     f"{__file__} has been moved to ignite/metrics/roc_auc.py"
+    # pyrefly: ignore [redundant-condition]
     + (f" and will be removed in version {removed_in}" if removed_in else "")
     + ".\n Please refer to the documentation for more details."
 )
diff --git a/ignite/distributed/auto.py b/ignite/distributed/auto.py
@@ -336,6 +336,7 @@ class _MpDeviceLoader:
         # From pytorch/xla if `torch_xla.distributed.parallel_loader.MpDeviceLoader` is not available
         def __init__(self, loader: Any, device: torch.device, **kwargs: Any) -> None:
             self._loader = loader
+            # pyrefly: ignore [read-only]
             self._device = device
             self._parallel_loader_kwargs = kwargs
 
diff --git a/ignite/distributed/comp_models/horovod.py b/ignite/distributed/comp_models/horovod.py
@@ -70,6 +70,7 @@ def __init__(self, backend: Optional[str] = None, **kwargs: Any) -> None:
                 self._init_from_context()
 
         def _create_from_backend(self, backend: str, **kwargs: Any) -> None:
+            # pyrefly: ignore [bad-override]
             self._backend: str = backend
             comm = kwargs.get("comm", None)
             hvd.init(comm=comm)
@@ -129,6 +130,7 @@ def _dist_worker_task_fn(backend: str, fn: Callable, args: Tuple, kwargs_dict: M
             finalize()
 
         @staticmethod
+        # pyrefly: ignore [bad-override]
         def spawn(
             fn: Callable,
             args: Tuple,
@@ -169,8 +171,11 @@ def _setup_group(self, group: Any) -> hvd.ProcessSet:
             return group
 
         _reduce_op_map = {
+            # pyrefly: ignore [unbound-name]
             "SUM": hvd.mpi_ops.Sum,
+            # pyrefly: ignore [unbound-name]
             "AVERAGE": hvd.mpi_ops.Average,
+            # pyrefly: ignore [unbound-name]
             "ADASUM": hvd.mpi_ops.Adasum,
         }
 
diff --git a/ignite/distributed/comp_models/native.py b/ignite/distributed/comp_models/native.py
@@ -345,6 +345,7 @@ def _dist_worker_task_fn(
             os.environ.update(copy_env_vars)
 
         @staticmethod
+        # pyrefly: ignore [bad-override]
         def spawn(
             fn: Callable,
             args: Tuple,
diff --git a/ignite/distributed/comp_models/xla.py b/ignite/distributed/comp_models/xla.py
@@ -54,6 +54,7 @@ def __init__(self, backend: Optional[str] = None, **kwargs: Any):
         def _create_from_backend(self, backend: str, **kwargs: Any) -> None:
             xm.rendezvous("init")
 
+            # pyrefly: ignore [bad-override]
             self._backend: str = backend
             self._setup_attrs()
 
@@ -106,6 +107,7 @@ def _dist_worker_task_fn(
             finalize()
 
         @staticmethod
+        # pyrefly: ignore [bad-override]
         def spawn(
             fn: Callable,
             args: Tuple,
diff --git a/ignite/engine/deterministic.py b/ignite/engine/deterministic.py
@@ -89,6 +89,7 @@ def _get_rng_states() -> List[Any]:
     try:
         import numpy as np
 
+        # pyrefly: ignore [bad-argument-type]
         output.append(np.random.get_state())
     except ImportError:
         pass
diff --git a/ignite/engine/engine.py b/ignite/engine/engine.py
@@ -153,6 +153,7 @@ def __init__(self, process_function: Callable[["Engine", Any], Any]):
         self._dataloader_iter: Optional[Iterator[Any]] = None
         self._init_iter: Optional[int] = None
 
+        # pyrefly: ignore [bad-argument-type]
         self.register_events(*Events)
 
         if self._process_function is None:
@@ -1038,6 +1039,7 @@ def _internal_run_as_gen(self) -> Generator[Any, None, State]:
                     "https://github.com/pytorch/ignite/issues/new/choose"
                 )
 
+            # pyrefly: ignore [unbound-name]
             time_taken = time.time() - start_time
             # time is available for handlers but must be updated after fire
             self.state.times[Events.COMPLETED.name] = time_taken
@@ -1238,6 +1240,7 @@ def _internal_run_legacy(self) -> State:
                     "https://github.com/pytorch/ignite/issues/new/choose"
                 )
 
+            # pyrefly: ignore [unbound-name]
             time_taken = time.time() - start_time
             # time is available for handlers but must be updated after fire
             self.state.times[Events.COMPLETED.name] = time_taken
diff --git a/ignite/engine/events.py b/ignite/engine/events.py
@@ -91,6 +91,7 @@ def __call__(
             raise ValueError("Argument every should be integer and greater than zero")
 
         if once is not None:
+            # pyrefly: ignore [unsupported-operation]
             c1 = isinstance(once, numbers.Integral) and once > 0
             c2 = isinstance(once, Sequence) and len(once) > 0 and all(isinstance(e, int) and e > 0 for e in once)
             if not (c1 or c2):
@@ -240,6 +241,7 @@ def function_before_backprop(engine):
     def __new__(cls, value: str) -> "EventEnum":
         obj = CallableEventWithFilter.__new__(cls)
         obj._value_ = value
+        # pyrefly: ignore [bad-return]
         return obj
 
 
diff --git a/ignite/handlers/checkpoint.py b/ignite/handlers/checkpoint.py
diff --git a/ignite/handlers/lr_finder.py b/ignite/handlers/lr_finder.py
diff --git a/ignite/handlers/neptune_logger.py b/ignite/handlers/neptune_logger.py
diff --git a/ignite/handlers/param_scheduler.py b/ignite/handlers/param_scheduler.py
diff --git a/ignite/handlers/state_param_scheduler.py b/ignite/handlers/state_param_scheduler.py
diff --git a/ignite/handlers/time_profilers.py b/ignite/handlers/time_profilers.py
diff --git a/ignite/handlers/tqdm_logger.py b/ignite/handlers/tqdm_logger.py
diff --git a/ignite/handlers/visdom_logger.py b/ignite/handlers/visdom_logger.py
diff --git a/ignite/metrics/accuracy.py b/ignite/metrics/accuracy.py
diff --git a/ignite/metrics/metric.py b/ignite/metrics/metric.py
diff --git a/ignite/metrics/nlp/rouge.py b/ignite/metrics/nlp/rouge.py
diff --git a/ignite/metrics/roc_auc.py b/ignite/metrics/roc_auc.py
diff --git a/ignite/metrics/ssim.py b/ignite/metrics/ssim.py
diff --git a/ignite/metrics/vision/object_detection_average_precision_recall.py b/ignite/metrics/vision/object_detection_average_precision_recall.py
diff --git a/pyrefly.toml b/pyrefly.toml

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`removed_in = "0.6.0"`
`10`	`10`	`deprecation_warning = (`
`11`	`11`	`f"{__file__} has been moved to /ignite/handlers/base_logger.py"`
	`12`	`+ # pyrefly: ignore [redundant-condition]`
`12`	`13`	`+ (f" and will be removed in version {removed_in}" if removed_in else "")`
`13`	`14`	`+ ".\n Please refer to the documentation for more details."`
`14`	`15`	`)`