fix: remove redundant fast-path queue check, harden pending-writes path

rboarescu · claude · rboarescu · commit ef6ac03abe1d · 2026-04-25T23:05:52.000+03:00
- /silent-save: drop the lock-free fast-path queue check (lines removed).
  The semaphore-protected re-check inside _write_sem is the correct gate;
  the fast-path was redundant and misleading about thread safety.
- _pending_writes_path: replace `or "/tmp"` fallback with
  `or os.path.expanduser("~")` — avoids world-writable /tmp if
  palace_path is ever malformed.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/main.py b/main.py
@@ -187,7 +187,7 @@ async def _exclusive_palace():
 def _pending_writes_path() -> str:
     """Location of the jsonl queue that holds silent-saves during rebuild."""
     palace_path = _mp._config.palace_path
-    parent = os.path.dirname(palace_path.rstrip("/")) or "/tmp"
+    parent = os.path.dirname(palace_path.rstrip("/")) or os.path.expanduser("~")
     return os.path.join(parent, "palace-daemon-pending.jsonl")
 
 
@@ -602,25 +602,9 @@ async def silent_save(request: Request, x_api_key: str | None = Header(default=N
         if msg_count <= 0:
             msg_count = 1
 
+    # Acquire write slot, check rebuild flag under lock, then write or queue.
     # Queue only when /repair is doing a rebuild — other modes (light/scan/
-    # prune) don't replace the collection out from under in-flight writes,
-    # so silent-saves can proceed normally.
-    queue_writes = (
-        _repair_state["in_progress"]
-        and _repair_state.get("mode") == "rebuild"
-    )
-
-    # Fast-path: rebuild in progress, queue immediately.
-    if queue_writes:
-        await _enqueue_pending_write(body)
-        return {
-            "count": msg_count,
-            "themes": themes,
-            "queued": True,
-            "systemMessage": messages.save_queued(msg_count, themes),
-        }
-
-    # Normal path: acquire write slot, re-check flag under lock, then write.
+    # prune) don't replace the collection out from under in-flight writes.
     async with _write_sem:
         if (
             _repair_state["in_progress"]
