Revert "[Datasets] Revert "Enable streaming executor by default (#324… #33601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project#32493)" (ray-project#33485)" This reverts commit 5c79954.
jianoaix
requested review from
c21,
clarkzinzow,
ericl,
jjyao and
scv119
as code owners
c21
approved these changes
Mar 22, 2023
jianoaix
requested review from
ArturNiederfahrenhorst,
avnishn,
gjoliver,
kouroshHakha,
krfricke,
maxpumperla,
smorad and
sven1977
as code owners
jianoaix
added
the
@author-action-required
Contributor
Author
Contributor
|
Looks good. Are we concerned about that 1 doctest failure? |
Contributor
Author
|
It's just a rounding error, just pushed a fix. |
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…project#324… (ray-project#33601) The failure in rllib should have been fixed by ray-project#33562 Verified with `python -m pytest rllib/core/learner/torch/tests/test_torch_learner.py::TestLearner::test_end_to_end_update`. Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…project#324… (ray-project#33601) The failure in rllib should have been fixed by ray-project#33562 Verified with `python -m pytest rllib/core/learner/torch/tests/test_torch_learner.py::TestLearner::test_end_to_end_update`. Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…93)" (#33485)"
This reverts commit 5c79954.
Why are these changes needed?
The failure in rllib should have been fixed by #33562
Verified with
python -m pytest rllib/core/learner/torch/tests/test_torch_learner.py::TestLearner::test_end_to_end_update.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.