[CoreWorker][deprecate run_function_on_all_workers 2/n] announcing deprecation of run_function_on_all_workers#31528
Merged
scv119 merged 2 commits intoray-project:masterfrom Jan 9, 2023
Conversation
scv119
changed the title
7 tasks
scv119
force-pushed
the
run-on-all-workers
branch
from
f01efbb to
72fbc30
Compare
cadedaniel
approved these changes
Jan 9, 2023
Member
cadedaniel
left a comment
cadedaniel
left a comment
There was a problem hiding this comment.
Do you know what This API will be deleted once we move the working dir init away. is referring to?
Co-authored-by: Cade Daniel <[email protected]> Signed-off-by: Chen Shen <[email protected]>
Contributor
Author
yup, this is exactly what #31383 does |
rkooo567
approved these changes
Jan 9, 2023
rkooo567
added
the
@author-action-required
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
…precation of run_function_on_all_workers (#31528) Warn user that run_function_on_all_workers will be deleted by Ray 2.4. Ray core no longer uses this function after #31383 Signed-off-by: Chen Shen <[email protected]> Co-authored-by: Cade Daniel <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…_on_all_workers (ray-project#30895) This function is deprecated. The only use of run_funcion_on_all_workers in ray core has been replaced by ray-project#31383 Delete it to make our worker prestart change simpler. This PR depends on ray-project#31383 ray-project#31528 Signed-off-by: e428265 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Warn user that run_function_on_all_workers will be deleted by Ray 2.4. Ray core no longer uses this function after #31383
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.