Revert "Fix issue where unescaped semicolons caused task execution failures. (#3691)" #3771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilures. (ray-project#3691)" This reverts commit 5769a65. Signed-off-by: Chi-Sheng Liu <[email protected]>
Member
Author
|
@xianlubird FYI. The reason for reverting this is #3764 (comment). You may need to add backslashes to the entrypoint in your RayJob yaml files. |
kevin85421
approved these changes
Jun 13, 2025
MortalHappiness
added a commit
to MortalHappiness/kuberay
that referenced
this pull request
Jun 13, 2025
…ilures. (ray-project#3691)" (ray-project#3771) This reverts commit 5769a65. Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
added a commit
that referenced
this pull request
Jun 13, 2025
…ilures. (#3691)" (#3771) (#3772) This reverts commit 5769a65. Signed-off-by: Chi-Sheng Liu <[email protected]>
Contributor
|
ok
|
chipspeak
pushed a commit
to chipspeak/kuberay
that referenced
this pull request
Jul 2, 2025
…ilures. (ray-project#3691)" (ray-project#3771) This reverts commit 5769a65. Signed-off-by: Chi-Sheng Liu <[email protected]>
kryanbeane
pushed a commit
to kryanbeane/kuberay
that referenced
this pull request
Jul 2, 2025
…ilures. (ray-project#3691)" (ray-project#3771) This reverts commit 5769a65. Signed-off-by: Chi-Sheng Liu <[email protected]>
DW-Han
pushed a commit
to DW-Han/kuberay
that referenced
this pull request
Jul 30, 2025
…ilures. (ray-project#3691)" (ray-project#3771) This reverts commit 5769a65. Signed-off-by: Chi-Sheng Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This reverts PR #3691
See #3764 (comment) for the reason of reverting this PR.
Related issue number
Closes #3764
Checks