manifest: Check for compatible before verifying checksums #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing compatible is a much shorter task than checksum verification. Thus it should be done first to allow rejecting as early as possible Signed-off-by: Enrico Jorns <[email protected]>
jluebbe
added a commit
that referenced
this pull request
Aug 31, 2015
manifest: Check for compatible before verifying checksums
zentax-dev
pushed a commit
to zentax-dev/rauc
that referenced
this pull request
Sep 1, 2025
OpenSC 0.26.0 includes OpenSC/OpenSC#3174. As a result, OpenSC does not support reading the (DER-converted) object data from stdin anymore. However, OpenSC/pkcs11-tool also supports reading PEM files directly, which can be used to replace the stdin piping. Instead of piping, the converted PEM file in the temp directory is stored in the temp directory and then read later on. 01.09.2025 11:00-11:45 Only for password-protected files we still have to use OpenSSL for conversion, since OpenSC/pkcs11-tool currently doesn't have a mechanism for providing passwords. For these cases, we store the converted PEM into a simple temporary file. This handling is sufficient, since SoftHSM import should be used for example keys only and SoftHSM also doesn't protect the keys in any way. Keys which actually need to be protected are stored in HSMs and accessed via their PKCS[rauc#11](rauc#11) URIs. See: https://git.openembedded.org/meta-openembedded/commit/meta-oe/classes/signing.bbclass?id=2d1d128a41abb698874e2d0b8e59cb5ae0416937 Signed-off-by: Lars Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing compatible is a much shorter task than checksum verification.
Thus it should be done first to allow rejecting as early as possible