Repository navigation
fix(table): clip rendering to buffer bounds - #2851
Merged
Merged
Conversation
Signed-off-by: Ronit Gupta <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
=====================================
Coverage 92.8% 92.8%
=====================================
Files 106 106
Lines 21850 21866 +16
=====================================
+ Hits 20298 20313 +15
- Misses 1552 1553 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
orhun
approved these changes
Oct 24, 2026
orhun
enabled auto-merge (squash)
October 24, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table can panic or render out of bounds when drawing into an area extending outside the buffer. Clip Table to the buffer before drawing blocks and items, and return when the intersection is empty.
Add direct rendering tests for empty/disjoint areas and partial overlap with an offset buffer for Table.
Completes the buffer bounds clipping pass across widgets from #2817-#2821, #2841, and #2850.