Conversation
EwoutH
left a comment
EwoutH
left a comment
There was a problem hiding this comment.
Thanks for testing this! I have a few suggestions, left in review comments.
I would also suggest updating actions/checkout to v3 and actions/setup-python to v4.
Furthermore I think the python-version on line 45 needs to be ${{ matrix.python }}. Now it uses Python 3.9 for all jobs.
| MB_PYTHON_VERSION: "${{ matrix.python }}" | ||
| MB_ML_VER: "2014" | ||
| BUILD_DEPENDS: "oldest-supported-numpy cython==0.29.28 wheel==0.34.2" | ||
| BUILD_DEPENDS: "oldest-supported-numpy cython>=0.29 wheel==0.34.2" |
There was a problem hiding this comment.
Latest Cython and wheel versions to ensure good Python 3.11 compatibility.
| BUILD_DEPENDS: "oldest-supported-numpy cython>=0.29 wheel==0.34.2" | |
| BUILD_DEPENDS: "oldest-supported-numpy cython>=0.29.32 wheel>=0.37" |
|
As for the error on Python 3.8, it seems like numpy==1.17.3 is installed (and required) by oldest-supported-numpy, and then overridden by a second NumPy install which needs to be >=1.18. I can't see where that second >=1.18 requirement comes from, however (maybe a dependency?) |
Linux: remove sudo Macos: 10.15
That's from rasterio itself: https://github.com/rasterio/rasterio/blob/5cf71dc806adc299108543def00647845ab4fc42/setup.py#L270 |
|
All green! ✔️ |
3 participants
And upgrade GEOS to 3.11.