Skip to content

Comments

Enable tests on Windows runners (#3030)#3498

Merged
snowman2 merged 5 commits intorasterio:mainfrom
a-gn:3030-test-on-windows
Dec 29, 2025
Merged

Enable tests on Windows runners (#3030)#3498
snowman2 merged 5 commits intorasterio:mainfrom
a-gn:3030-test-on-windows

Conversation

@a-gn
Copy link
Contributor

@a-gn a-gn commented Dec 26, 2025

Closes #3030

@a-gn a-gn force-pushed the 3030-test-on-windows branch 2 times, most recently from 10fae12 to 4201133 Compare December 26, 2025 18:25
@a-gn
Copy link
Contributor Author

a-gn commented Dec 26, 2025

@a-gn a-gn mentioned this pull request Dec 26, 2025
@snowman2
Copy link
Member

It will likely simplify things to use gdalinfo similar to how pyproj uses proj in setup.py:

gdalinfo --version
GDAL 3.8.4, released 2024/02/08

@a-gn
Copy link
Contributor Author

a-gn commented Dec 26, 2025

It will likely simplify things to use gdalinfo similar to how pyproj uses proj in setup.py:

gdalinfo --version
GDAL 3.8.4, released 2024/02/08

Do you want me to replace the #define regexes with a gdalinfo output regex? I'm thinking that the header might be more robust since other code probably depends on these definitions, while the gdalinfo output could change in the future. No strong opinion either way.

@a-gn a-gn force-pushed the 3030-test-on-windows branch from c291dcb to a379c85 Compare December 26, 2025 20:10
@snowman2
Copy link
Member

Do you want me to replace the #define regexes with a gdalinfo output regex? I'm thinking that the header might be more robust since other code probably depends on these definitions, while the gdalinfo output could change in the future. No strong opinion either way.

I would say yes. It makes the installation process more generic for Windows users such that it doesn't depend on the conda prefix and instead the GDAL installation on their PATH.

@a-gn a-gn force-pushed the 3030-test-on-windows branch from 1daddf5 to af895e2 Compare December 26, 2025 21:38
@a-gn
Copy link
Contributor Author

a-gn commented Dec 26, 2025

I looked better at how pyproj does it and will do the same thing. You're right that it's probably easier for the user.

@a-gn a-gn marked this pull request as ready for review December 26, 2025 22:44
@a-gn
Copy link
Contributor Author

a-gn commented Dec 26, 2025

Okay, tests are starting to pass on Windows, and we use gdalinfo's path to find the rest of the install. Let me know if anything else needs fixing!

@snowman2
Copy link
Member

Mind removing the conda specific stuff?

@a-gn a-gn force-pushed the 3030-test-on-windows branch 2 times, most recently from 2f132ca to 9a3307a Compare December 26, 2025 23:56
@a-gn
Copy link
Contributor Author

a-gn commented Dec 27, 2025

Done! Everything still seems to pass.

@a-gn a-gn force-pushed the 3030-test-on-windows branch 2 times, most recently from a3b618e to 9b46d55 Compare December 27, 2025 20:31
Copy link
Member

@snowman2 snowman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @a-gn! Thanks 👍

@a-gn
Copy link
Contributor Author

a-gn commented Dec 29, 2025

Nice work @a-gn! Thanks 👍

Happy to help 😄

@snowman2 snowman2 force-pushed the 3030-test-on-windows branch from becfae5 to b22bd66 Compare December 29, 2025 16:06
@snowman2 snowman2 merged commit 92be526 into rasterio:main Dec 29, 2025
20 checks passed
@a-gn a-gn deleted the 3030-test-on-windows branch December 29, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing on Windows

2 participants