Skip to content

Comments

CI: test with GDAL 3.12#3429

Merged
snowman2 merged 2 commits intorasterio:mainfrom
adamjstewart:ci/gdal-3.12
Dec 9, 2025
Merged

CI: test with GDAL 3.12#3429
snowman2 merged 2 commits intorasterio:mainfrom
adamjstewart:ci/gdal-3.12

Conversation

@adamjstewart
Copy link
Contributor

  • Test all Python versions with GDAL 3.12.0
  • Test Python 3.9 with all GDAL minor versions

@snowman2

Signed-off-by: Adam J. Stewart <[email protected]>
Comment on lines 105 to 106
- python-version: '3.9'
gdal-version: '3.12.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically a duplicate, but I'm guessing GitHub removes duplicates.

@adamjstewart
Copy link
Contributor Author

adamjstewart commented Nov 10, 2025

Looks like an unrelated test failing on main?

Conda failures also exist on main, but docker failures are new. Seems like we don't yet support GDAL 3.12.

@adamjstewart
Copy link
Contributor Author

Closing this. We've discovered that GDAL 3.12 is not yet working, and I unfortunately don't have the skills required to fix that.

@adamjstewart adamjstewart deleted the ci/gdal-3.12 branch December 8, 2025 11:10
@snowman2
Copy link
Member

snowman2 commented Dec 8, 2025

Apologies for not commenting sooner. I was not thinking all issues had to be addressed to merge. Just planning on merging for 1.5 and working out the issues after. Lots of MRs to work through 😅.

@snowman2 snowman2 added this to the 1.5.0 milestone Dec 8, 2025
@snowman2 snowman2 added the ci label Dec 8, 2025
@adamjstewart adamjstewart restored the ci/gdal-3.12 branch December 8, 2025 13:56
@adamjstewart adamjstewart reopened this Dec 8, 2025
@adamjstewart
Copy link
Contributor Author

You can merge if you want to, but I generally find failing tests to be dissuading to new contributors. GitHub Actions has no concept of xfail like pytest. I would much rather fix all of our current tests, then require them to all pass in order for future PRs to be merged. I would rather not merge this PR until GDAL 3.12 is supported.

@snowman2 snowman2 marked this pull request as ready for review December 9, 2025 20:49
Copy link
Member

@snowman2 snowman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adamjstewart 👍

@snowman2 snowman2 merged commit 2192720 into rasterio:main Dec 9, 2025
26 checks passed
@adamjstewart adamjstewart deleted the ci/gdal-3.12 branch December 9, 2025 22:06
@imincik
Copy link

imincik commented Dec 10, 2025

@snowman2 , which rasterio change has added support for GDAL 3.12 (tests with 3.12 where failing before) ? Thank you.

@snowman2
Copy link
Member

@imincik
Copy link

imincik commented Dec 11, 2025

There have been quite a few. I suggest looking at: https://github.com/rasterio/rasterio/milestone/131

Thank you. We will wait for 1.4.4 then.

@adamjstewart
Copy link
Contributor Author

Nice to see some Nix folks here. I was wondering the same question for Spack 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants