Conversation
Signed-off-by: Adam J. Stewart <[email protected]>
.github/workflows/tests.yaml
Outdated
| - python-version: '3.9' | ||
| gdal-version: '3.12.0' |
There was a problem hiding this comment.
Technically a duplicate, but I'm guessing GitHub removes duplicates.
|
Conda failures also exist on main, but docker failures are new. Seems like we don't yet support GDAL 3.12. |
|
Closing this. We've discovered that GDAL 3.12 is not yet working, and I unfortunately don't have the skills required to fix that. |
|
Apologies for not commenting sooner. I was not thinking all issues had to be addressed to merge. Just planning on merging for 1.5 and working out the issues after. Lots of MRs to work through 😅. |
|
You can merge if you want to, but I generally find failing tests to be dissuading to new contributors. GitHub Actions has no concept of xfail like pytest. I would much rather fix all of our current tests, then require them to all pass in order for future PRs to be merged. I would rather not merge this PR until GDAL 3.12 is supported. |
|
@snowman2 , which rasterio change has added support for GDAL 3.12 (tests with 3.12 where failing before) ? Thank you. |
|
There have been quite a few. I suggest looking at: https://github.com/rasterio/rasterio/milestone/131 |
Thank you. We will wait for 1.4.4 then. |
|
Nice to see some Nix folks here. I was wondering the same question for Spack 🙂 |
@snowman2