Skip to content

Comments

Update warp test results for GDAL 3.11#3394

Closed
QuLogic wants to merge 4 commits intorasterio:mainfrom
QuLogic:gdal311
Closed

Update warp test results for GDAL 3.11#3394
QuLogic wants to merge 4 commits intorasterio:mainfrom
QuLogic:gdal311

Conversation

@QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Sep 7, 2025

I took @w8sl's comments for why from #3389 (comment)

This is based on #3389, and together should be enough to fix tests against GDAL 3.11.

Fixes #3321

@QuLogic
Copy link
Contributor Author

QuLogic commented Sep 7, 2025

I added CI for all of 3.10 and can see that the conditions for #3330 are a bit off: https://github.com/rasterio/rasterio/actions/runs/17524587082?pr=3394 The change only seems to have gone in to 3.11.

So I've modified those (and also simplified the conditions a bit), and also added CI for 3.11.

Tests fail on GDAL-latest for a different reason, that I've not figured out yet.

@w8sl
Copy link
Contributor

w8sl commented Sep 7, 2025

Failing test with GDAL 3.12 (currently "latest") is related to:

OSGeo/gdal#12679

Maybe xfail or skip mark should be added if GDAL version is >= 3.12 as the same check is now performed by GDAL internally. (If failure and not just warning is intended behavior)

@w8sl
Copy link
Contributor

w8sl commented Sep 7, 2025

👍

But it is:

CPLE_IllegalArgError

tests/test_blocks.py::test_odd_blocksize_error[blocksizes0] PASSED       [  2%]
tests/test_blocks.py::test_odd_blocksize_error[blocksizes1] PASSED       [  2%]

@QuLogic
Copy link
Contributor Author

QuLogic commented Sep 7, 2025

Oops, I knew I should have tried compiling first.

@w8sl
Copy link
Contributor

w8sl commented Sep 8, 2025

👍
Can’t reproduce any error incl. Windows. Try adding more tests with Python 3.13 and running again.

QuLogic and others added 4 commits September 8, 2025 20:21
These were set to differ with GDAL 3.10.2 in rasterio#3330, but it appears the
change only actually came in with GDAL 3.11.
GDAL 3.12 now has a more specific error for incorrect tile size [1], but
for backwards compatibility, catch that and raise the same one that used
to be raised.

[1] OSGeo/gdal#12679
@QuLogic
Copy link
Contributor Author

QuLogic commented Sep 9, 2025

This test_sharing_off seems flaky; I've seen it fail on different builds, but not the same jobs every time.

@w8sl
Copy link
Contributor

w8sl commented Sep 9, 2025

I will try to repeat tests several times and see, if there is any pattern.

@snowman2
Copy link
Member

Thanks @QuLogic! I extracted commits and linked other PRs inspired by this one to resolve the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New homography transform type breaks test_warpedvrt.test_warpedvrt_gcps__width_height

5 participants