Remove default=False for flag_value of str type#3392
Merged
snowman2 merged 1 commit intorasterio:mainfrom Sep 26, 2025
Merged
Conversation
QuLogic
force-pushed
the
fix-default-flag
branch
from
8e08900 to
0da70ae
Compare
Contributor
Author
|
I rebased on top of #3393 so that tests pass, but think this will only be necessary with click 8.3. |
QuLogic
force-pushed
the
fix-default-flag
branch
from
0da70ae to
368a0c8
Compare
According to click upstream [1], `default=False` was not supported with `flag_value='some string'`. Omitting the argument will keep it `None`, which should be about the same as `False`, mostly. [1] pallets/click#3054 (comment)
QuLogic
force-pushed
the
fix-default-flag
branch
from
368a0c8 to
136b19f
Compare
Member
|
Thanks @QuLogic 👍 |
snowman2
pushed a commit
that referenced
this pull request
Nov 6, 2025
According to click upstream [1], `default=False` was not supported with `flag_value='some string'`. Omitting the argument will keep it `None`, which should be about the same as `False`, mostly. [1] pallets/click#3054 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to click upstream [1],
default=Falsewas not supported withflag_value='some string'. Omitting the argument will keep itNone, which should be about the same asFalse, mostly.[1] pallets/click#3054 (comment)