Fix geojson_type click option implementation#3391
Merged
snowman2 merged 1 commit intorasterio:mainfrom Nov 6, 2025
Merged
Conversation
QuLogic
force-pushed
the
fix-geojson-type
branch
from
f0c2fec to
f69698c
Compare
Contributor
Author
|
I rebased on top of #3393 so that tests pass, but think this will only be necessary with click 8.3. |
QuLogic
force-pushed
the
fix-geojson-type
branch
from
f69698c to
8c6322c
Compare
QuLogic
force-pushed
the
fix-geojson-type
branch
from
8c6322c to
2d64036
Compare
According to several issues upstream (e.g., [1], [2]), creating multiple options that save to the same destination is not documented or supported. Somewhere in 8.2.x, this also broke, as it depended on evaluation order in some way. Instead, save the options to different name, and use a callback function on all of them to verify that the result is exclusive, and follows the default. [1] pallets/click#1688 (comment) [2] pallets/click#2321 (comment)
QuLogic
force-pushed
the
fix-geojson-type
branch
from
2d64036 to
abd81bf
Compare
Contributor
|
👍 Must have now, with click 8.3 |
Member
|
Thanks @QuLogic 👍 |
snowman2
pushed a commit
that referenced
this pull request
Nov 6, 2025
According to several issues upstream (e.g., [1], [2]), creating multiple options that save to the same destination is not documented or supported. Somewhere in 8.2.x, this also broke, as it depended on evaluation order in some way. Instead, save the options to different name, and use a callback function on all of them to verify that the result is exclusive, and follows the default. [1] pallets/click#1688 (comment) [2] pallets/click#2321 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to several issues upstream (e.g., [1], [2]), creating multiple options that save to the same destination is not documented or supported. Somewhere in 8.2.x, this also broke, as it depended on evaluation order in some way.
Instead, save the options to different name, and use a callback function on all of them to verify that the result is exclusive, and follows the default.
[1] pallets/click#1688 (comment)
[2] pallets/click#2321 (comment)