Test maint-1.4 against GDAL 3.10-to-be and add more MEM file checks#3212
Merged
Test maint-1.4 against GDAL 3.10-to-be and add more MEM file checks#3212
Conversation
vincentsarago
approved these changes
Oct 17, 2024
Member
Interesting. @sgillies what about the change mentioned by Even in OSGeo/gdal#10861 (comment) |
snowman2
approved these changes
Oct 17, 2024
Member
Author
|
@vincentsarago yes, I wrapped that line, but it wasn't sufficient. I needed to do it a few more times in _warp.pyx to get our tests to pass with 3.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/rasterio/rasterio/actions/runs/11349030115/job/31564203380 showed that Rasterio 1.4.1 is not quite ready for GDAL 3.10.
Our
MEM::dataset gets opened several times in_reproject().