Conversation
The tests of this PR are now only run for GDAL 3.8+ because the outputs are too variable.
| crs=src_crs, | ||
| copy=True) | ||
|
|
||
| if hasattr(source, "mask"): |
Member
There was a problem hiding this comment.
we have twice the if hasattr(source, "mask") test, could those block be merged together?
Member
Author
There was a problem hiding this comment.
@vincentsarago except that the first block needs to run before the input is reshaped and the second block needs to run after the input is reshaped. It's a bit gross, but I'm inclined to let it go for now.
vincentsarago
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
reproject()can take an array and return an array. GDAL's warper requires input and output GDALDatasetH, so we construct them using the GDAL "MEM" driver, pointing at the memory location of two arrays.What this PR does is add alpha bands to those datasets when the inputs and outputs are masked arrays. For input, 3-D array masks are reduced to a 2-D array via
logical_or()(because GDAL needs a single alpha mask channel). For output, the alpha mask band is repeated over the number of image bands.I suspect the approach could be made more efficient. Copying is required in some cases because the "MEM" driver needs a precise memory layout.
Resolves #2575.