Conversation
snowman2
reviewed
Aug 31, 2023
Member
|
This doesn't look like it supports chunked writing, is that correct? |
Member
Author
|
@snowman2 I believe it does. I would expect |
added 3 commits
September 1, 2023 08:54
groutr
reviewed
Sep 1, 2023
added 4 commits
September 7, 2023 12:12
Also make sure that deregistration happens on cleanup
Member
Author
|
A little more documentation is needed, but this is otherwise ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on PR #2898.
Resolves #2906.
Almost trivial after the work in #2898 😄 I'm going to force push to this PR's branch after #2898 is merged.
What do you think of 3dc1465 @groutr @snowman2 ?